re-add ConfigSourceFactory #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be replaced, once there is an official way to access higher-order config (see eclipse/microprofile-config#470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt of #3:
We want our ConfigSource to read configurations from sources with lower ordinals. MP Config does not support this yet (see eclipse/microprofile-config#470), but Smallrye Config makes this possible via ConfigSourceFactories.
@infeo used this approach already, but due to problems with non-singleton config instances (one per class loader), we decided to use a less complex (but also less capable) approach.
Now the situation changed, as being able to read existing configs is nonnegotiable for proper unit tests.