-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove default node #2072
Conversation
✅ Deploy Preview for specter-desktop-docs canceled.
|
Thank you for the heads up. Sounds like the Raspiblitzes should work as normal after this change. The rpcpassword is the same for the nodes on all networks. |
…esktop into chore/rid_of_defaultnode
src/cryptoadvance/specter/node.py
Outdated
|
||
@property | ||
def bitcoin_core_version_raw(self): | ||
raise Exception() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What? raise OR return!
* change passwordaspin auth implementation * env-var for RASPIBLITZ_SPECTER_RPC_LOGIN_BITCOIN_CONF_LOCATION * remove default * fix tests * fix the tests part2 * fix cypress tests * docstrings and other default removals * improve error_handling * do not raise exception
* Chore: Remove default node (#2072) * change passwordaspin auth implementation * env-var for RASPIBLITZ_SPECTER_RPC_LOGIN_BITCOIN_CONF_LOCATION * remove default * fix tests * fix the tests part2 * fix cypress tests * docstrings and other default removals * improve error_handling * do not raise exception * fixed debugging artifact * Spinning refresh icon if node is still syncing * Cypress test for sync status * remove notification of fully synced node * Set timeout for sync check to 5min --------- Co-authored-by: moneymanolis <[email protected]> Co-authored-by: Manolis Mandrapilias <[email protected]>
@k9ert we are running into an error repeatedly in raspiblitz/raspiblitz#3709:
The config is (+ tried some variations):
Logs:
The
Can you help please about how should we change the config? |
The default node is quite annoying and makes things super complicated. This PR schould change that so that a default node is no longer needed.
rpcpasswordaspin
which is used by raspiblitz to no longer use the default node. Instead it now simply assumes that there is an active node connection and if that is not the case, it searches the harddrive in the folder/mnt/hdd/bitcoin
for abitcoin.conf
file and uses the connection details in that file to validate that the rpc-connection is valid with the password the user has provided. If that folder changes for some reason, it can be changed via modifying theRASPIBLITZ_SPECTER_RPC_LOGIN_BITCOIN_CONF_LOCATION
env var. If the connection is not available (e.g. node down) the user can still login as the password is validated in that case with string comparison.src/cryptoadvance/specter/server_endpoints/auth.py
was heavily refactored.class NonExistingNode(PersistentObject)
. Whenever there is no node, then instead ofNone
, an instance of this class is returned. It returns some minimum values which probably should get shrinked even further if we would continue to refactor the frontend-code.