Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui Feature: Global search #1832

Open
wants to merge 132 commits into
base: master
Choose a base branch
from
Open

Ui Feature: Global search #1832

wants to merge 132 commits into from

Conversation

relativisticelectron
Copy link
Collaborator

@relativisticelectron relativisticelectron commented Aug 3, 2022 •
edited
Loading

See: #1593 and #1795

Peek 2022-08-11 10-48

TODO:

  • The design/css need improvement
  • translations
  • refactor subresults for consistent naming
  • refactor endpoint functions
  • take in account the hidden-sensitive-content
  • add pytest
  • Add cypress
  • allow datetime search
  • move this to a new service.
  • When the no-secure-storage-required PR is merged (link ) then also add that this service doesn't need secure storage.
  • Make the service opt-out, see Feature: Notification system #1766 (comment) and rebase after Feature: Notification system #1766 (comment) is merged

Out of scope (ideas for folllow-up PRs)

  • apply the search term to the txlist filter input (and add filter input to address list)
  • search through settings, such that you can search for "PDF export"

@relativisticelectron
working search field, no functionality
660faa7
@relativisticelectron
working data structure
89ddef2
@relativisticelectron
rough but working....
44d4571
@relativisticelectron
color reset works
9c64aa1
@relativisticelectron
working solution for visibility based on url
19dd23f
@relativisticelectron
extened to recieve
27245c7
@relativisticelectron
partial address search
5b300c6
@relativisticelectron
working tx search
13030a3
@relativisticelectron
working tx filter
f1fcc61
@relativisticelectron
bugfix
e49523f
@relativisticelectron
change and recieve sub highlighting works
fd06496
@relativisticelectron
unsigned psbt search works
6699990
@relativisticelectron
changed to POST and device key search working
263b3fd
@relativisticelectron
fixed persistent color
487c249 
and added searches of more addresses
@relativisticelectron
utxo search
d5705f2
@relativisticelectron
lower case comparision and better keys highlighting
56bd036
@relativisticelectron
corrected tx list call
c4ac959
@relativisticelectron
styling
f051ab0
@relativisticelectron
styling
4cdc69e
@relativisticelectron
added search for wallet names
176f81b
@relativisticelectron
better styling
893091f
@relativisticelectron
fix for strip
6458fcc
@relativisticelectron
working search delay to avoid lagging while rappidly typing
3367005
@relativisticelectron
doc
391a5cf
@relativisticelectron
pytest fix
52b121b
@relativisticelectron
moved search bar to sidebar
5a72501
@relativisticelectron
fix
387f8e1
@relativisticelectron
bugfix
2017ffc
@relativisticelectron
title added
663e47a
@relativisticelectron
Merge remote-tracking branch 'cryptoadvance/master' into 20220710_search
4efe607
@relativisticelectron
Copy link
Collaborator Author

Cypress is green for me locally.

@k9ert
Copy link
Collaborator

k9ert commented Aug 22, 2022 •
edited
Loading

2nd prio, notification system ist first prio.

@relativisticelectron
Copy link
Collaborator Author

relativisticelectron commented Aug 25, 2022 •
edited
Loading

I prevent searching (almost anything) if in hide sensitive mode. However I do not know if this is the correct way to handle it because I do not understand the threat model the hide sensitive mode should protect against #1170 (comment) .

Somehow preventing search is silly, because a single click on the "eye/unhide" button reveals everything.....

@relativisticelectron
Merge branch 'master' into 20220801_search_list
664119e
@relativisticelectron
Merge remote-tracking branch 'cryptoadvance/master' into 20220801_sea…
ebbd0cf 
…rch_list

# Conflicts:
#	src/cryptoadvance/specter/server_endpoints/wallets_api.py
#	tests/test_ep_controller.py
@k9ert
Copy link
Collaborator

k9ert commented Sep 27, 2022

I agree: What should a hide-mode provide which is not easier provided with a auto-logout.

@relativisticelectron
Copy link
Collaborator Author

I agree: What should a hide-mode provide which is not easier provided with a auto-logout.

Since #1170 (comment) did not get an answer, maybe it is time to think about removing this feature?

@moneymanolis
Copy link
Collaborator

Since #1170 (comment) did not get an answer, maybe it is time to think about removing this feature?

Fine by me to remove it.

@k9ert
Copy link
Collaborator

k9ert commented Sep 27, 2022

Since #1170 (comment) did not get an answer,
maybe it is time to think about removing this feature?

Fine by me and also fine by @moneymanolis . Go for it if you want to make that effort!

@skwp
Copy link

skwp commented Sep 29, 2022

this looks really nice!

@relativisticelectron relativisticelectron mentioned this pull request Oct 2, 2022
Merged
15 tasks
@moneymanolis
Copy link
Collaborator

@relativisticelectron please hold on removing the Hide sensitive info mode for now. This might be useful after all, we need to discuss this internally.

@relativisticelectron relativisticelectron mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@relativisticelectron @moneymanolis @k9ert @skwp