Update info page to include stake activities, Recent tx and mixer running. #247
Conversation
your PR figma @dreacot please update text when clicked info button on mixer section |
|
LGTM Please align to the right margin |
resolved |
There was a problem hiding this comment.
app Crash when switching between info and other tabs
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x58 pc=0x1883540]
goroutine 58 [running]:
github.com/crypto-power/cryptopower/ui/page/send.(*Page).initializeAccountSelectors.func3(0xc00a5d9600?)
D:/Works/Decred/cryptopower/ui/page/send/page.go:214 +0x80
github.com/crypto-power/cryptopower/ui/page/components.(*WalletAndAccountSelector).SelectFirstValidAccount(0xc00466e600, 0x25235a0?)
D:/Works/Decred/cryptopower/ui/page/components/wallet_account_selector.go:129 +0xbd
github.com/crypto-power/cryptopower/ui/page/send.(*Page).OnNavigatedTo(0xc008c42000)
D:/Works/Decred/cryptopower/ui/page/send/page.go:268 +0x97
github.com/crypto-power/cryptopower/app.(*PageStack).Push(0xc003f27200, {0x251cf60, 0xc008c42000}, {0x2520890, 0xc00afda890})
D:/Works/Decred/cryptopower/app/pagestack.go:67 +0x4f0
github.com/crypto-power/cryptopower/app.(*MasterPage).Display(0xc00afda890, {0x251cf60?, 0xc008c42000?})
D:/Works/Decred/cryptopower/app/masterpage.go:46 +0x33
github.com/crypto-power/cryptopower/ui/page/root.(*MainPage).HandleUserInteractions.func1({0x251cf60, 0xc008c42000})
D:/Works/Decred/cryptopower/ui/page/root/main_page.go:264 +0x45
github.com/crypto-power/cryptopower/ui/page/root.(*MainPage).HandleUserInteractions(0xc00325a240)
D:/Works/Decred/cryptopower/ui/page/root/main_page.go:295 +0x416
github.com/crypto-power/cryptopower/ui/page/root.(*HomePage).HandleUserInteractions(0xc000229680)
D:/Works/Decred/cryptopower/ui/page/root/home_page.go:195 +0x56
github.com/crypto-power/cryptopower/ui.(*Window).handleFrameEvent(0xc003cf06c0, {{0xc14fa20eeffada8c, 0x119053563d, 0x3243fa0},
{0x3f800000, 0x3f800000}, {0x320, 0x28a}, {0x0, 0x0, ...}, ...})
D:/Works/Decred/cryptopower/ui/window.go:227 +0x147
github.com/crypto-power/cryptopower/ui.(*Window).HandleEvents(0xc003cf06c0)
D:/Works/Decred/cryptopower/ui/window.go:200 +0x236
main.main.func3()
D:/Works/Decred/cryptopower/main.go:109 +0x17
created by main.main in goroutine 1
D:/Works/Decred/cryptopower/main.go:107 +0x4e9
exit status 2
|
the recent transaction and staking activity margins are not consistent with what we have on figma
|
The reason it does not look like figma is because we are already in a selected wallet screen. Figma assumes that we are displaying txs from multi wallets. I have however adopted the design on figma. |
This bug is reproducible in master, and its caused by navigating to the send page or pages using the wallet selector with a watch-only wallet. I will open an issue for it. |
|
LGTM |
Your previous implementation is correct as figma made the mistake of assuming multiple wallets. Please revert What i pointed out in my original comment was margin issues, and not the content of the tx rows. The bottom Margin after recent transactions is more that what's on figma The left right margins are also more than what we have on figma The divider line starta more left that the figma design |
Fix #210