Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New layout for trade page #218

Merged
merged 4 commits into from
Oct 31, 2023
Merged

New layout for trade page #218

merged 4 commits into from
Oct 31, 2023

Conversation

Vanvians
Copy link
Collaborator

Closes #80

ukane-philemon
ukane-philemon reviewed Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@ukane-philemon ukane-philemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing well on desktop.

ui/page/root/trade_page.go Outdated Show resolved Hide resolved
ui/page/root/trade_page.go Outdated Show resolved Hide resolved
ukane-philemon
ukane-philemon previously requested changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@ukane-philemon ukane-philemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look straightforward but I could not test mobile.

ui/page/root/trade_page.go Outdated Show resolved Hide resolved
dreacot
dreacot requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the view all order button no longer works

Screenshot from 2023-10-30 10-20-51

@Vanvians
Copy link
Collaborator Author

View all order button fixed in latest commit

@Vanvians Vanvians requested a review from dreacot October 31, 2023 11:34
@dreacot dreacot merged commit bbba92e into crypto-power:master Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreacot dreacot dreacot approved these changes

@Sirmorrison Sirmorrison Awaiting requested review from Sirmorrison

@ukane-philemon ukane-philemon Awaiting requested review from ukane-philemon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement the new design for the landing page of the trade tab
3 participants
@Vanvians @dreacot @ukane-philemon