-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add send modal click functionality from overview page #176
Conversation
8195f8b
to
3619d5e
Compare
3619d5e
to
1645455
Compare
da224aa
to
b7676d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hovering on the "wallet or address" btns hides the text with the bg color, unable to select wallet accounts to send to and got panic
Screen.Recording.2023-10-12.at.10.50.58.PM.mov
Panic log:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x68 pc=0x100dd66ad]
goroutine 43 [running]:
github.com/crypto-power/cryptopower/ui/page/components.(*selectorModal).modalListItemLayout.func2({{{0x3c, 0x0}, {0x3c, 0xf4218}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_account_selector.go:697 +0xed
gioui.org/layout.Flex.Layout({0xbf?, 0x2?, 0x0?, 0x0?}, {{{0x0, 0x0}, {0x25c, 0xf4218}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/flex.go:134 +0x738
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1.2.1.1.1({{{0x0, 0x0}, {0x25c, 0xf4218}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:88 +0x85
gioui.org/layout.Direction.Layout(0x0, {{{0x0, 0x0}, {0x25c, 0xf4218}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:196 +0x162
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1.2.1.1({{{0x25c, 0x0}, {0x25c, 0xf4218}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:87 +0xe5
gioui.org/layout.Inset.Layout({0xd1e0?, 0x0?, 0xe000?, 0x0?}, {{{0x25c, 0x0}, {0x25c, 0xf4218}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:169 +0x39d
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1.2.1({{{0x25c, 0x0}, {0x25c, 0xf4238}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:85 +0x109
github.com/crypto-power/cryptopower/ui/cryptomaterial.Border.Layout({{0x0, 0x0, 0x0, 0x0}, {0x0, 0x0, 0x0, 0x0}, 0x0}, {{{0x25c, ...}, ...}, ...}, ...)
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/border.go:21 +0x98
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1.2({{{0x25c, 0x0}, {0x25c, 0xf4238}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:83 +0x1d6
gioui.org/layout.Stack.Layout({0x2c?}, {{{0x0, 0x0}, {0x25c, 0xf4238}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/stack.go:60 +0x195
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1({{{0x0, 0x0}, {0x25c, 0xf4238}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:46 +0x2aa
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1({{{0x0, 0x0}, {0x25c, 0xf4238}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:105 +0x238
gioui.org/layout.Inset.Layout({0x78be120?, 0xc0?, 0x397?, 0x0?}, {{{0x0, 0x0}, {0x25c, 0xf4238}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:169 +0x39d
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1({{{0x0, 0x0}, {0x25c, 0xf4240}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:44 +0x109
gioui.org/layout.Direction.Layout(0x0, {{{0x0, 0x0}, {0x25c, 0xf4240}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:196 +0x162
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout({0xfffffffffffffffe, 0xffffffffffffffff, 0x0, {0x0, 0x0, 0x0, 0x0}, 0x0, {{0x0, 0x0, ...}, ...}, ...}, ...)
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:42 +0xe5
github.com/crypto-power/cryptopower/ui/page/components.(*selectorModal).modalListItemLayout(0xc00731d400, {{{0x0, 0x0}, {0x25c, 0xf4240}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_account_selector.go:647 +0x485
github.com/crypto-power/cryptopower/ui/page/components.(*selectorModal).Layout.func2.2.1.1({{{0x0, 0x0}, {0x25c, 0xf4240}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...}, ...)
/Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_account_selector.go:587 +0x65
gioui.org/layout.(*List).Layout(0xc00731d470, {{{0x0, 0x0}, {0x25c, 0xf4240}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/list.go:122 +0x17c
github.com/crypto-power/cryptopower/ui/page/components.(*selectorModal).Layout.func2.2.1({{{0x0, 0x0}, {0x25c, 0xf422c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_account_selector.go:586 +0x85
gioui.org/layout.Stack.Layout({0x0?}, {{{0x25c, 0x0}, {0x25c, 0xf422c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/stack.go:78 +0x498
github.com/crypto-power/cryptopower/ui/page/components.(*selectorModal).Layout.func2.2({{{0x25c, 0x0}, {0x25c, 0xf422c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_account_selector.go:584 +0x12b
gioui.org/layout.Flex.Layout({0x9a?, 0x51?, 0x33?, 0x35?}, {{{0x25c, 0x0}, {0x25c, 0xf422c}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/flex.go:99 +0x2d5
github.com/crypto-power/cryptopower/ui/page/components.(*selectorModal).Layout.func2({{{0x25c, 0x0}, {0x25c, 0xf422c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_account_selector.go:545 +0x1b8
gioui.org/layout.Inset.Layout({0x2b4?, 0x0?, 0x2b3?, 0x0?}, {{{0x25c, 0x0}, {0x25c, 0xf422c}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:169 +0x39d
github.com/crypto-power/cryptopower/ui/cryptomaterial.(*Modal).Layout.func2.1.2.2.1({{{0x25c, 0x0}, {0x25c, 0xf4240}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...}, ...)
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/modal.go:177 +0xa5
gioui.org/layout.(*List).Layout(0xc00757e3d0, {{{0x25c, 0x0}, {0x25c, 0xf4240}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/list.go:122 +0x17c
gioui.org/widget/material.ListStyle.Layout({0xc00757e380, {0xc00757e380, {0x40000000, 0x40000000, {0x0, 0x0, 0x0, 0x0}}, {0x42180000, 0x40c00000, ...}}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/widget/material/list.go:290 +0x20c
github.com/crypto-power/cryptopower/ui/cryptomaterial.ListStyle.Layout(...)
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/list_scroll.go:39
github.com/crypto-power/cryptopower/ui/cryptomaterial.(*Modal).Layout.func2.1.2.2({{{0x0, 0x0}, {0x270, 0x413}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/modal.go:175 +0x1c5
gioui.org/layout.Flex.Layout({0xad?, 0x2?, 0x0?, 0x0?}, {{{0x0, 0x0}, {0x270, 0x43c}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/flex.go:99 +0x2d5
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1.2.1.1.1({{{0x0, 0x0}, {0x270, 0x43c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:88 +0x85
gioui.org/layout.Direction.Layout(0x8, {{{0x0, 0x0}, {0x270, 0x43c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:196 +0x162
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1.2.1.1({{{0x0, 0x0}, {0x270, 0x43c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:87 +0xe5
gioui.org/layout.Inset.Layout({0x441?, 0x0?, 0x0?, 0x0?}, {{{0x0, 0x0}, {0x270, 0x43c}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:169 +0x39d
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1.2.1({{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:85 +0x109
github.com/crypto-power/cryptopower/ui/cryptomaterial.Border.Layout({{0x0, 0x0, 0x0, 0x0}, {0xe, 0xe, 0xe, 0xe}, 0x0}, {{{0x0, ...}, ...}, ...}, ...)
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/border.go:21 +0x98
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1.2({{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:83 +0x1d6
gioui.org/layout.Stack.Layout({0x0?}, {{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/stack.go:60 +0x195
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1.1({{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:46 +0x2aa
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1.1({{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:105 +0x238
gioui.org/layout.Inset.Layout({0x0?, 0x0?, 0x0?, 0x0?}, {{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:169 +0x39d
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout.func1({{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:44 +0x109
gioui.org/layout.Direction.Layout(0x8, {{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:196 +0x162
github.com/crypto-power/cryptopower/ui/cryptomaterial.LinearLayout.Layout({0xffffffffffffffff, 0xffffffffffffffff, 0x1, {0xff, 0xff, 0xff, 0xff}, 0x0, {{0x0, 0x0, ...}, ...}, ...}, ...)
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/linearlayout.go:42 +0xe5
github.com/crypto-power/cryptopower/ui/cryptomaterial.(*Modal).Layout.func2.1.2({{{0x0, 0x0}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/modal.go:146 +0x3ac
gioui.org/layout.Stack.Layout({0x0?}, {{{0x0, 0x49c}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/stack.go:60 +0x195
github.com/crypto-power/cryptopower/ui/cryptomaterial.(*Modal).Layout.func2.1({{{0x0, 0x49c}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/modal.go:128 +0x2cd
gioui.org/layout.Inset.Layout({0x0?, 0x0?, 0x0?, 0x0?}, {{{0x0, 0x49c}, {0x2d0, 0x49c}}, {0x40000000, 0x40000000}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/layout.go:169 +0x39d
github.com/crypto-power/cryptopower/ui/cryptomaterial.(*Modal).Layout.func2({{{0x0, 0x514}, {0x2d0, 0x514}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/modal.go:127 +0x371
gioui.org/layout.Stack.Layout({0x20?}, {{{0x0, 0x0}, {0x640, 0x514}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/stack.go:60 +0x195
github.com/crypto-power/cryptopower/ui/cryptomaterial.(*Modal).Layout(0xc007524d20, {{{0x0, 0x0}, {0x640, 0x514}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/Desktop/osp/cryptopower/ui/cryptomaterial/modal.go:96 +0x30d
github.com/crypto-power/cryptopower/ui/page/components.(*selectorModal).Layout(0xc00731d400, {{{0x0, 0x0}, {0x640, 0x514}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/page/components/wallet_account_selector.go:596 +0x1c8
github.com/crypto-power/cryptopower/ui.(*Window).prepareToDisplayUI.func3({{{0x0, 0x0}, {0x640, 0x514}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, 0x35a333519a, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/window.go:293 +0x58
gioui.org/layout.Stack.Layout({0x20?}, {{{0x640, 0x514}, {0x640, 0x514}}, {0x40000000, 0x40000000}, {0x101aa1b00, 0xc002f580c8}, {0xc14238731abee4b0, ...}, ...}, ...)
/Users/philemon/go/pkg/mod/[email protected]/layout/stack.go:60 +0x195
github.com/crypto-power/cryptopower/ui.(*Window).prepareToDisplayUI(0xc002ed0140, {{0xc14238731abee4b0, 0x35a333519a, 0x10275c220}, {0x40000000, 0x40000000}, {0x640, 0x514}, {0x0, 0x0, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/window.go:300 +0x40d
github.com/crypto-power/cryptopower/ui.(*Window).handleFrameEvent(0xc002ed0140, {{0xc14238731abee4b0, 0x35a333519a, 0x10275c220}, {0x40000000, 0x40000000}, {0x640, 0x514}, {0x0, 0x0, ...}, ...})
/Users/philemon/Desktop/osp/cryptopower/ui/window.go:241 +0x225
github.com/crypto-power/cryptopower/ui.(*Window).HandleEvents(0xc002ed0140)
/Users/philemon/Desktop/osp/cryptopower/ui/window.go:206 +0x2b9
main.main.func3()
/Users/philemon/Desktop/osp/cryptopower/main.go:110 +0x1d
created by main.main
/Users/philemon/Desktop/osp/cryptopower/main.go:108 +0x54e
exit status 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can select a wallet that's still syncing from the wallet selector, we should notify users if that's the case for a selected wallet. because an unsynced wallet could provide false info to the user
something similar to what's done on the receive page
you can't access the original send/receive page if a wallet is syncing
i also see we rightfully left out coin control, the general send/receive modal is so easy that people might end up defaulting to this, we also need to find a way to notify that coin control is available, probably not a work for this PR, we could let the designers figure this out
48b8ffb
to
e0b019e
Compare
Fix #89
This PR implement the send modal functionality when then the send page is clicked from the page navigator.
It currently uses the send page layout with some minor updates.