Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add txs and stakes to the overview page #157

Merged
merged 13 commits into from
Oct 24, 2023

Conversation

crux25
Copy link
Collaborator

@crux25 crux25 commented Oct 6, 2023

This MR adds tx and staking data on the overview page. Closes #84

Screenshot from 2023-10-09 16-44-22

@crux25 crux25 marked this pull request as ready for review October 9, 2023 15:43
@dreacot
Copy link
Member

dreacot commented Oct 9, 2023

the "vote" text and the wallet name seem misaligned

Screenshot from 2023-10-09 15-24-26

@dreacot
Copy link
Member

dreacot commented Oct 9, 2023

  1. mixed funds also seem to be preceded by a negative sign
  2. the confirmation icons is also missing from the mixing row

Screenshot from 2023-10-09 15-43-02

Copy link
Collaborator

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass

ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
@dreacot
Copy link
Member

dreacot commented Oct 16, 2023

staking activities only show one item for me, when i have hundreds of staking activity

the decred logo and wallet name is still not aligned on mixed and staking transactions

Screenshot from 2023-10-16 11-18-08

ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
@crux25
Copy link
Collaborator Author

crux25 commented Oct 17, 2023

staking activities only show one item for me, when i have hundreds of staking activity

the decred logo and wallet name is still not aligned on mixed and staking transactions

Screenshot from 2023-10-16 11-18-08

The staking activities, does it say "Vote"?

@crux25 crux25 requested review from Sirmorrison, dreacot and ukane-philemon and removed request for ukane-philemon October 19, 2023 15:33
@dreacot
Copy link
Member

dreacot commented Oct 19, 2023

staking activities only show one item for me, when i have hundreds of staking activity
the decred logo and wallet name is still not aligned on mixed and staking transactions
Screenshot from 2023-10-16 11-18-08

The staking activities, does it say "Vote"?

i'm not sure what you mean?

this is my staking list (watch only wallet)

Screenshot from 2023-10-19 11-28-40

this is what i see on overview page
Screenshot from 2023-10-19 11-27-37

Copy link
Member

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2023-10-24 10-59-43

title of staking activity is needs to be adjusted

ui/page/root/overview_page.go Outdated Show resolved Hide resolved
ui/page/root/overview_page.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these minor changes the PR looks good to go.

ui/page/components/components.go Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/components/components.go Outdated Show resolved Hide resolved
ui/page/root/overview_page.go Show resolved Hide resolved
@dreacot dreacot merged commit dab134b into crypto-power:master Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[overview page]: populate the recent transaction and staking activities cards with real data
5 participants