Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home: Reverse sync toggle logic. #154

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

JoeGruffins
Copy link
Collaborator

Allows the toggle to start sync.

Comment on lines -105 to +106
if !hp.WL.SelectedWallet.Wallet.IsConnectedToNetwork() {
if hp.WL.SelectedWallet.Wallet.IsConnectedToNetwork() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change needed... but please have a look at the rest as I think it was missing some thread safety for the isConnected bool and a way out of the connecting loop if ctx is canceled.

Copy link
Member

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreacot dreacot merged commit ebf4622 into crypto-power:master Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants