fix exchange rate bugs #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Return early for dcr-ltc market as Binance does not support it yet. - Fix the bug that caused weird estimated rates. - Improve the estimated rates display. - Fix comment formatting and typos. Signed-off-by: Philemon Ukane <[email protected]>
|
binance rate still shows on the order scheduler modal
|
dreacot
requested changes
Oct 4, 2023
Nice catch. I was unable to sync LTC atm and could not test without syncing. EDIT: Resolved in f9d5e3f. |
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
dcr-ltcmarket as Binance does not support it yet.Note:
instantswap.ExchangeRateInfo.EstimatedAmountwas previously unused but it gives the correct values for it's current use so I'm using it instead ofinstantswap.ExchangeRateInfo.ExchangeRate.