-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement total USD asset balance #131
Conversation
Did a little test and noticed:
|
please resolve branch conflicts |
on testing the functionality i noticed there might have been a miscommunication with the way this should work, the total USD Balance, works with the
@ukane-philemon is right, remove the toggle, if rate fetching is enabled from the settings page, then it's enabled everywhere including the total usd balance, if it's disabled in settings, then it's disabled everywhere also the text should change to "Total USD value" Also please update the info text to say that this feature can be enabled or disabled from the app settings |
f1d31a6
to
c4511a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libwallet/assets_config.go
Outdated
// IsTotalAssetBalanceOn checks if the total usd balance is set. | ||
func (mgr *AssetsManager) IsTotalAssetBalanceOn() bool { | ||
var data bool | ||
mgr.db.ReadWalletConfigValue(sharedW.TotalUSDBalanceConfigKey, &data) | ||
return data | ||
} | ||
|
||
// SetTransactionsNotifications sets the transaction notifications for the wallet. | ||
func (mgr *AssetsManager) SetTotalAssetBalanceState(data bool) { | ||
mgr.db.SaveWalletConfigValue(sharedW.TotalUSDBalanceConfigKey, data) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think these are used anymore
Fix #77