Problem: gravity-bridge orchestrators don't reject unprofitable messages from cronos to ethereum #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges from cronos to ethereum Solution: Reject unprofitable messages. Also adds logic of a timeout duration after which the batch is sent even if it is unprofitable. Fixes crypto-org-chain/cronos#99
tomtau
reviewed
Sep 30, 2021
thomas-nguy
reviewed
Mar 4, 2022
There was a problem hiding this comment.
I will try to port this to v0.3.8-cronos (https://github.com/crypto-org-chain/gravity-bridge/tree/v0.3.8-cronos)
@devashishdxt what are the pending tasks for this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Reject unprofitable messages. Also adds logic of a timeout duration after which the batch is sent even if it is unprofitable.
Fixes crypto-org-chain/cronos#99