Problem: get set params are not align in evm #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #456 +/- ##
===========================================
+ Coverage 62.92% 62.94% +0.02%
===========================================
Files 127 127
Lines 12067 12062 -5
===========================================
Hits 7593 7593
+ Misses 3933 3930 -3
+ Partials 541 539 -2
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yihuang
reviewed
Apr 5, 2024
x/feemarket/keeper/params.go
Outdated
| @@ -30,8 +30,12 @@ func (k Keeper) GetParams(ctx sdk.Context) types.Params { | |||
| objStore := ctx.ObjectStore(k.objectKey) | |||
| v := objStore.Get(types.KeyPrefixObjectParams) | |||
| if v == nil { | |||
| store := k.storeService.OpenKVStore(ctx) | |||
There was a problem hiding this comment.
What's the difference here, using store service vs store key?
There was a problem hiding this comment.
return is different, and we need panic if err right?
There was a problem hiding this comment.
the behavior is identical, the old store also panic on invalid input.
But the store service introduce extra memory allocation for the wrapper, I want to remove them.
mmsqe
changed the title
yihuang
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)