Problem: fee deduction not compatible with parallel execution #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
Apr 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #447 +/- ##
===========================================
- Coverage 63.36% 63.29% -0.08%
===========================================
Files 125 125
Lines 12061 12075 +14
===========================================
Hits 7643 7643
- Misses 3875 3889 +14
Partials 543 543
|
there'll be another PR for that, one pr one issue. |
mmsqe
approved these changes
Apr 2, 2024
Solution: - use virtual send Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> fix build fix test cleanup
zsystm
pushed a commit
to b-harvest/ethermint
that referenced
this pull request
Jun 3, 2024
… execution (crypto-org-chain#447) Reason for Cherry-pick: - Integrate Block STM (Parallel Transaction Execution) - Avoid common conflict problem (fee collection happens for every tx) - Add TODOs to track newly added code while cherry pick - (To-do) handler_test.go and state_transition_test.go remains same and some tests are broken. let's fix out. Notes - Use b-harvest's cosmos-sdk which applies minimum requirements for integrating block-stm - Use No-op app mempool currently, do it later - Skip Flags (UnsafeSkipUpgrades, InvCheckPeriod, Home) which are already injected when creating EthermintApp - Remain original code structures (maybe refactored or changed later referencing related commit) - Authz module has begin blocker, feegrant module has end blocker. both were located under no-op modules comment. - Original Commit Message: * Problem: fee deduction not compatible with parallel execution Solution: - use virtual send * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * fix build * fix test * cleanup --------- Signed-off-by: yihuang <[email protected]> Cherry-picked-by: zsystm <[email protected]>
zsystm
added a commit
to b-harvest/ethermint
that referenced
this pull request
Jun 5, 2024
Reason for Cherry-pick: - refactor noisy codes by referencing cronos ethermint's well structured testing suite - consider virtual balance for fee collector module because some tests does not trigger ante handler (e.g. direct handler call) Note: - this cherry pick came from crypto-org-chain#447 - why additional commit? some interfaces are not compatible because of geth version diff and sdk diff. Cherry-picked-by: zsystm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)