forked from evmos/ethermint
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: custom cache store impl not unified with sdk #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
Apr 1, 2024
yihuang
commented
Apr 1, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #446 +/- ##
===========================================
+ Coverage 62.56% 63.36% +0.80%
===========================================
Files 130 125 -5
Lines 12513 12061 -452
===========================================
- Hits 7829 7643 -186
+ Misses 4138 3875 -263
+ Partials 546 543 -3
|
Solution: - unify the refactored cache store with sdk Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> mount object stores fix fix test cleanup fix ctx fix lint
yihuang
commented
Apr 2, 2024
yihuang
commented
Apr 2, 2024
yihuang
commented
Apr 2, 2024
mmsqe
approved these changes
Apr 2, 2024
Signed-off-by: yihuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Closes: #XXX
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)