Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode filtered logs in ws (backport: #1781) #251

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 2, 2023

for more info: evmos#1781

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe force-pushed the release/v0.20.x-cronos-fix-log branch from 6218fa1 to d60f21c Compare June 2, 2023 05:25
@mmsqe mmsqe marked this pull request as ready for review June 2, 2023 09:32
@mmsqe mmsqe changed the title fix: decode filtered logs in ws fix: decode filtered logs in ws (backport: #1781) Jun 2, 2023
@mmsqe mmsqe force-pushed the release/v0.20.x-cronos-fix-log branch from df23524 to 9cc8515 Compare June 2, 2023 10:25
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #251 (132c405) into release/v0.20.x-cronos (0ea7b86) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #251      +/-   ##
==========================================================
- Coverage                   52.56%   52.52%   -0.04%     
==========================================================
  Files                         113      113              
  Lines                       11073    11091      +18     
==========================================================
+ Hits                         5820     5826       +6     
- Misses                       5006     5017      +11     
- Partials                      247      248       +1     
Impacted Files Coverage Δ
rpc/namespaces/ethereum/eth/filters/api.go 0.00% <0.00%> (ø)
x/evm/types/utils.go 62.16% <30.76%> (-10.57%) ⬇️

@mmsqe mmsqe requested a review from yihuang June 5, 2023 02:44
@mmsqe mmsqe merged commit 2136ad0 into crypto-org-chain:release/v0.20.x-cronos Jun 5, 2023
mmsqe added a commit that referenced this pull request Jun 14, 2023
* fix: decode filtered logs in ws (backport: evmos#1781) (#251)

* fix decode logs in ws

* add test

* add change doc

* decode in single loop

* add ci timeout

* reset max-tx-gas-wanted

* fix rest filter api

* test batch tx with exist sc

* more filter tests

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants