Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): chain-id in grpc query is not initialized without abci event (backport: #1405) #215

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 8, 2023

for more info

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

…mos#1405)

* fix: chain-id in grpc query is not initialized without abci event

Closes: evmos#1404

Solution:
- pass the chain-id from caller.

* Update CHANGELOG.md

* only override if input is not empty

* add comment to chain id

* pass chain-id to state transition

* Update x/evm/keeper/grpc_query.go

* Apply suggestions from code review

* fix golang lint

* update gomod2nix.toml

* fix unit tests

* update gomod2nix

* api breaking changelog

* add unit tests, and fix TraceBlock by the way

* Update CHANGELOG.md

* test --grpc-only mode in integration tests

* remove tmp var

* Update tests/integration_tests/test_grpc_only.py

* Update x/evm/keeper/grpc_query_test.go

Co-authored-by: mmsqe <[email protected]>

* fix linters

* fix nil pointer in tests

* fix conflicts

* fix conflicts

* fixes

* fix lint

* fix unit test

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Co-authored-by: Freddy Caceres <[email protected]>
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #215 (68b4541) into release/v0.20.x-cronos (9b24b9b) will increase coverage by 0.12%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #215      +/-   ##
==========================================================
+ Coverage                   57.27%   57.39%   +0.12%     
==========================================================
  Files                         108      108              
  Lines                       10104    10082      -22     
==========================================================
  Hits                         5787     5787              
+ Misses                       4071     4049      -22     
  Partials                      246      246              
Impacted Files Coverage Δ
rpc/backend/call_tx.go 0.00% <0.00%> (ø)
rpc/backend/tracing.go 0.00% <0.00%> (ø)
x/evm/keeper/grpc_query.go 87.58% <100.00%> (ø)

@mmsqe mmsqe force-pushed the v0.20.x-cronos-backport-1405 branch from 283028b to 68b4541 Compare March 8, 2023 07:52
@mmsqe mmsqe marked this pull request as draft March 8, 2023 09:10
@mmsqe mmsqe closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants