Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cannot send to cosmos with proxy contract when its a source token #997

Merged

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Fix logic in the proxy contract
Add integration tests

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner April 24, 2023 03:00
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #997 (da31b1b) into main (b262fa8) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   44.94%   44.93%   -0.01%     
==========================================
  Files          80       80              
  Lines        6713     6707       -6     
==========================================
- Hits         3017     3014       -3     
+ Misses       3368     3366       -2     
+ Partials      328      327       -1     
Impacted Files Coverage Δ
x/cronos/keeper/keeper.go 77.01% <50.00%> (+0.97%) ⬆️

@thomas-nguy thomas-nguy force-pushed the thomas/fix-crc20-prox7-source branch from 5f406fb to 64fa86e Compare April 25, 2023 11:53
@thomas-nguy thomas-nguy enabled auto-merge April 26, 2023 00:41
@thomas-nguy thomas-nguy disabled auto-merge April 26, 2023 00:41
@thomas-nguy thomas-nguy added this pull request to the merge queue Apr 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 26, 2023
@thomas-nguy thomas-nguy added this pull request to the merge queue Apr 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 26, 2023
@thomas-nguy thomas-nguy added this pull request to the merge queue Apr 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 26, 2023
@thomas-nguy thomas-nguy added this pull request to the merge queue Apr 26, 2023
Merged via the queue into crypto-org-chain:main with commit 37ca344 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants