Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set IAVLDisableFastNode = false #740

Closed

Conversation

catShaark
Copy link

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

  • I set srvCfg.IAVLDisableFastNode = false in app config to avoid app hash error when node upgrade to dragon berry patch
  • Update ics23 dependency

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@catShaark catShaark requested a review from a team as a code owner October 16, 2022 15:07
@catShaark catShaark requested review from yihuang and adu-crypto and removed request for a team October 16, 2022 15:07
@adu-crypto
Copy link
Contributor

I believe theapp hash error that you mentioned should be related to this pr in iavl:
cosmos/iavl#589
maybe we could upgrade iavl to fix this error?

@catShaark
Copy link
Author

I believe theapp hash error that you mentioned should be related to this pr in iavl:

cosmos/iavl#589

maybe we could upgrade iavl to fix this error?

Yeah I believe so too

@yihuang
Copy link
Collaborator

yihuang commented Oct 18, 2022

I set srvCfg.IAVLDisableFastNode = false in app config to avoid app hash error when node upgrade to dragon berry patch

This option is changeable in app.toml, do you want to change the default value?

cmd/cronosd/cmd/root.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@catShaark
Copy link
Author

catShaark commented Oct 18, 2022

since iavl-disable-fastnode is already false by default in app.toml, I close this PR

@catShaark catShaark closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants