Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: basic json-rpc failed on pruned nodes #550

Merged
merged 6 commits into from
Jul 4, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 14, 2022

Solution:

  • Make basic json-rpc apis (get tx, get block) works on pruned nodes
  • Test with integration tests

ref: #451, improve user experience of pruned nodes.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang changed the title Problem: json-rpc failed on pruned nodes Problem: basic json-rpc failed on pruned nodes Jun 14, 2022
go.mod Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as ready for review June 30, 2022 04:01
@yihuang yihuang requested a review from a team as a code owner June 30, 2022 04:01
@yihuang yihuang requested review from JayT106, adu-crypto and thomas-nguy and removed request for a team June 30, 2022 04:01
Solution:
- Make basic json-rpc apis works on pruned nodes
- Test with integration tests
yihuang added a commit to yihuang/cronos that referenced this pull request Jun 30, 2022
Solution:
- Make basic json-rpc apis works on pruned nodes
- Test with integration tests
yihuang added a commit to yihuang/cronos that referenced this pull request Jun 30, 2022
Solution:
- Make basic json-rpc apis works on pruned nodes
- Test with integration tests
x/cronos/rpc/api.go Outdated Show resolved Hide resolved
integration_tests/test_pruned_node.py Show resolved Hide resolved
@yihuang yihuang requested a review from adu-crypto July 4, 2022 01:42
Copy link
Contributor

@adu-crypto adu-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yihuang yihuang merged commit 03fa9df into crypto-org-chain:main Jul 4, 2022
@yihuang yihuang deleted the test-pruned-rpc branch July 4, 2022 02:21
yihuang added a commit to yihuang/cronos that referenced this pull request Jul 4, 2022
Solution:
- Make basic json-rpc apis works on pruned nodes
- Test with integration tests

fix test config
yihuang added a commit that referenced this pull request Jul 4, 2022
* Problem: json-rpc failed on pruned nodes (backport #550)

Solution:
- Make basic json-rpc apis works on pruned nodes
- Test with integration tests

fix test config

* Update x/cronos/rpc/api.go

* use tags/ldflags directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants