-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: basic json-rpc failed on pruned nodes #550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
changed the title
Problem: json-rpc failed on pruned nodes
Problem: basic json-rpc failed on pruned nodes
Jun 14, 2022
yihuang
commented
Jun 14, 2022
yihuang
commented
Jun 15, 2022
yihuang
requested review from
JayT106,
adu-crypto and
thomas-nguy
and removed request for
a team
June 30, 2022 04:01
Solution: - Make basic json-rpc apis works on pruned nodes - Test with integration tests
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Jun 30, 2022
Solution: - Make basic json-rpc apis works on pruned nodes - Test with integration tests
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Jun 30, 2022
Solution: - Make basic json-rpc apis works on pruned nodes - Test with integration tests
adu-crypto
reviewed
Jul 1, 2022
adu-crypto
approved these changes
Jul 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
yihuang
added a commit
to yihuang/cronos
that referenced
this pull request
Jul 4, 2022
Solution: - Make basic json-rpc apis works on pruned nodes - Test with integration tests fix test config
yihuang
added a commit
that referenced
this pull request
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
ref: #451, improve user experience of pruned nodes.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)