Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: recent version of cosmos-sdk is not used #441

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 26, 2022

Solution:

  • bump patch version of dependencies.

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

remove replace statement

bump cosmos-sdk
@yihuang yihuang requested a review from a team as a code owner April 26, 2022 06:05
@yihuang yihuang requested review from calvinaco and adu-crypto and removed request for a team April 26, 2022 06:05
@yihuang yihuang mentioned this pull request Apr 26, 2022
13 tasks
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #441 (36b9ab4) into main (3ea70c5) will increase coverage by 19.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #441       +/-   ##
===========================================
+ Coverage   21.51%   41.06%   +19.54%     
===========================================
  Files          27       30        +3     
  Lines        1729     1505      -224     
===========================================
+ Hits          372      618      +246     
+ Misses       1324      841      -483     
- Partials       33       46       +13     
Impacted Files Coverage ฮ”
x/cronos/genesis.go 61.53% <รธ> (-38.47%) โฌ‡๏ธ
x/cronos/handler.go 100.00% <รธ> (รธ)
x/cronos/keeper/evm.go 58.00% <รธ> (+6.27%) โฌ†๏ธ
x/cronos/keeper/evm_hooks.go 80.00% <รธ> (รธ)
x/cronos/keeper/evm_log_handlers.go 83.50% <รธ> (รธ)
x/cronos/keeper/gravity_hooks.go 0.00% <รธ> (รธ)
x/cronos/keeper/grpc_query.go 0.00% <รธ> (รธ)
x/cronos/keeper/ibc.go 83.20% <รธ> (+5.01%) โฌ†๏ธ
x/cronos/keeper/ibc_hooks.go 50.00% <รธ> (-8.83%) โฌ‡๏ธ
x/cronos/keeper/keeper.go 64.89% <รธ> (-29.45%) โฌ‡๏ธ
... and 28 more

@yihuang yihuang requested a review from thomas-nguy April 26, 2022 06:32
github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.1.1

github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-8.0.20220420023806-5b624f76d0fc
github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-8.0.20220426061757-2f302a3a876b
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihuang yihuang merged commit d4a38ae into crypto-org-chain:main Apr 26, 2022
@yihuang yihuang deleted the v0.7.x_rocks branch April 26, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants