-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: empty topics in rpc response is not tested #255
Problem: empty topics in rpc response is not tested #255
Conversation
64c767d
to
36d6972
Compare
go.mod
Outdated
@@ -164,4 +164,4 @@ replace github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethere | |||
// TODO: remove when ibc-go and ethermint upgrades cosmos-sdk | |||
replace github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.44.2 | |||
|
|||
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.2-cronos-4 | |||
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.2-cronos-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably also add the ante handler fix at the same time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that one should be fixed privately first I think.
36d6972
to
7e06738
Compare
0f2262e
to
3821950
Compare
backport: crypto-org-chain#254 Solution: - merge empty topics fix - add integration tests to verify Update integration_tests/shell.nix Update CHANGELOG.md
7676b07
to
5e42eef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
backport: #254
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)