Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: rustc in nixpkgs is too old #1469

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 11, 2024

update nixpkgs to 24.05 that contains rustc 1.76.0

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Bug Fixes

    • Improved transaction handling to better manage responses and query events based on transaction hash.
  • Chores

    • Updated various package revisions and SHA-256 hashes to ensure compatibility and security.
    • Added pyyaml as a development dependency for integration tests.
  • Refactor

    • Removed unnecessary client_config sections from validator configurations for cleaner setup.

Copy link
Contributor

coderabbitai bot commented Jun 11, 2024

Walkthrough

The recent changes focus on refining integration tests and dependency management. Key updates include removing redundant client_config sections from configuration files, enhancing transaction response handling in cosmoscli.py, updating dependencies in nix files, and adding pyyaml as a development dependency. These adjustments streamline configurations, improve transaction processing, and ensure compatibility with updated package versions.

Changes

File(s) Change Summary
integration_tests/configs/ibc.jsonnet Removed client_config section within each validator configuration block.
integration_tests/configs/ibc_rly.jsonnet Removed client_config section with 'broadcast-mode': 'block' from the ibc configuration block.
integration_tests/cosmoscli.py Enhanced transaction response handling by checking for specific codes and querying events based on TX hash if code is 0.
integration_tests/pyproject.toml Added pyyaml as a development dependency with version ^6.0.2rc1.
nix/default.nix Updated buildGoModule assignment for go-ethereum from pkgs.buildGo120Module to pkgs.buildGo121Module.
nix/sources.json Updated revision and SHA-256 hash values for various packages, and updated URLs to point to new revisions' tarballs on GitHub.

Poem

In the land of code where rabbits hop,
Configs were trimmed, the clutter to stop.
Dependencies updated, the path now clear,
Transactions flow smoothly, without any fear.
With YAML in the mix, and Go modules anew,
The system now dances, in harmony true.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.54%. Comparing base (7866871) to head (f447c0e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1469       +/-   ##
===========================================
- Coverage   35.85%   17.54%   -18.32%     
===========================================
  Files         136       87       -49     
  Lines        9806     5273     -4533     
===========================================
- Hits         3516      925     -2591     
+ Misses       5894     4238     -1656     
+ Partials      396      110      -286     

see 72 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review June 11, 2024 04:41
@mmsqe mmsqe requested a review from a team as a code owner June 11, 2024 04:41
@mmsqe mmsqe requested review from calvinaco and devashishdxt and removed request for a team June 11, 2024 04:41
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7866871 and 576d9ce.

Files ignored due to path filters (1)
  • integration_tests/poetry.lock is excluded by !**/*.lock
Files selected for processing (6)
  • integration_tests/configs/ibc.jsonnet (1 hunks)
  • integration_tests/configs/ibc_rly.jsonnet (1 hunks)
  • integration_tests/cosmoscli.py (4 hunks)
  • integration_tests/pyproject.toml (1 hunks)
  • nix/default.nix (1 hunks)
  • nix/sources.json (4 hunks)
Files skipped from review due to trivial changes (1)
  • integration_tests/configs/ibc_rly.jsonnet
Additional comments not posted (5)
nix/default.nix (1)

11-11: Update to buildGo121Module looks good. Ensure all dependencies of go-ethereum are compatible with Go 1.21.

integration_tests/configs/ibc.jsonnet (1)

Line range hint 1-1: Removal of client_config sections seems aligned with simplifying configurations. Verify that this does not adversely affect any dependent systems or processes.

nix/sources.json (1)

8-11: Updates to the sources with new revisions and hashes are noted. Ensure the integrity of the sources by verifying the SHA-256 hashes match the actual content of the downloaded files.

Also applies to: 57-60, 81-84, 105-108

integration_tests/cosmoscli.py (2)

Line range hint 347-364: The updated error handling in the transfer method improves robustness by checking transaction response codes and querying events based on the transaction hash. Ensure that the event_query_tx_for method correctly handles all possible cases.


Line range hint 1561-1576: The changes in the register_counterparty_payee method enhance error handling by checking the transaction response code and querying events based on the transaction hash if the code is 0. Verify that the event_query_tx_for method is robust and handles all edge cases effectively.

integration_tests/pyproject.toml Outdated Show resolved Hide resolved
@mmsqe mmsqe enabled auto-merge June 11, 2024 05:17
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 576d9ce and f447c0e.

Files ignored due to path filters (1)
  • integration_tests/poetry.lock is excluded by !**/*.lock
Files selected for processing (1)
  • integration_tests/pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (1)
  • integration_tests/pyproject.toml

@mmsqe mmsqe added this pull request to the merge queue Jun 11, 2024
Merged via the queue into crypto-org-chain:main with commit ca52eac Jun 11, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants