Problem: rocksdb is out of date #1448
Conversation
Solution: - upgrade to v9.1.1
WalkthroughThe recent updates focus on upgrading the RocksDB dependency across various files in the project. Specifically, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Signed-off-by: yihuang <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
go.modis excluded by!**/*.modgo.sumis excluded by!**/*.sum
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- gomod2nix.toml (1 hunks)
- nix/rocksdb.nix (1 hunks)
Files skipped from review due to trivial changes (2)
- gomod2nix.toml
- nix/rocksdb.nix
Additional Context Used
LanguageTool (47)
CHANGELOG.md (47)
Near line 20: The conjunction “when” requires the past participle “registered”. Or did you mean “you register”?
Context: ...ronos/pull/1421) Validate e2ee key when register. * (store) [#1448](https://github.com/c...
Near line 122: Did you mean “or”? ‘Of’ refers to parts of a whole, while ‘or’ refers to alternatives.
Context: ...onos/pull/1216) Update ethermint to fix of avoid redundant parse chainID from gens...
Near line 163: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...n processing and double spend check. - [cronos#742](https://github.com/crypto-org-chai...
Near line 164: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha2. - [cronos#750](https://github.com/crypto-org-chai...
Near line 165: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e handler for v0.8.0-gravity-alpha3. - [cronos#769](https://github.com/crypto-org-chai...
Near line 166: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...cope of the contract that manage it. - [cronos#775](https://github.com/crypto-org-chai...
Near line 167: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...775) Support turnbridge transaction. - [cronos#781](https://github.com/crypto-org-chai...
Near line 168: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../cronos/pull/781) Add prune command. - [cronos#830](https://github.com/crypto-org-chai...
Near line 171: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...upgrade handler for v2.0.0-testnet3. - [cronos#795](https://github.com/crypto-org-chai...
Near line 172: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: .../795) Support permissions in cronos. - [cronos#997](https://github.com/crypto-org-chai...
Near line 173: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ontract for cronos originated crc20. - [cronos#1005](https://github.com/crypto-org-cha...
Near line 174: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...o-ibc event in case of source token. - [cronos#1069](https://github.com/crypto-org-cha...
Near line 175: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ov1.10.26and ibc-go tov6.2.0. - [cronos#1147](https://github.com/crypto-org-cha...
Near line 179: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...adjusted correctly in ibc-go v7.2.0. - [cronos#1163](https://github.com/crypto-org-cha...
Near line 180: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ateful precompiled contract for ica. - [cronos#837](https://github.com/crypto-org-chai...
Near line 181: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...teful precompiled contract for bank. - [cronos#1184](https://github.com/crypto-org-cha...
Near line 182: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ull/1184) Update ibc-go tov7.3.1. - [cronos#1186](https://github.com/crypto-org-cha...
Near line 183: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... max block gas limit in new version. - [cronos#1187](https://github.com/crypto-org-cha...
Near line 184: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...1187) Disable gravity module in app. - [cronos#1185](https://github.com/crypto-org-cha...
Near line 185: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nos/pull/1185) Support ibc callback. - [cronos#1196](https://github.com/crypto-org-cha...
Near line 204: It seems that “to” is missing before the verb.
Context: .../cronos/pull/1150) Fix memiavl's unsafe retain of the root hashes. ### Features - [#...
Near line 208: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: .../pull/1042) call Close method on app to cleanup resource on graceful shutdown ([ethermi...
Near line 324: After ‘it’, use the third-person verb form “fixes”.
Context: ...790) Update cosmos-sdk tov0.46.7, it fix a migration issue which affects pending...
Near line 391: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...file state streamer (backport #702). - [cronos#730](https://github.com/crypto-org-chai...
Near line 413: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...elSendToChain support from evm call. - [cronos#600](https://github.com/crypto-org-chai...
Near line 414: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...plement bidirectional token mapping. - [cronos#611](https://github.com/crypto-org-chai...
Near line 415: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...owledgement error in ibc middleware. - [cronos#627](https://github.com/crypto-org-chai...
Near line 430: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...leware, use ibc-go upstream version. - [cronos#550](https://github.com/crypto-org-chai...
Near line 431: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...basic json-rpc apis on pruned nodes. - [cronos#549](https://github.com/crypto-org-chai...
Near line 432: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...tom tx indexer feature of ethermint. - [cronos#673](https://github.com/crypto-org-chai...
Near line 450: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ed in json-rpc apis (backport #502). - [cronos#526](https://github.com/crypto-org-chai...
Near line 451: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... Fix tendermint duplicated tx issue. - [cronos#584](https://github.com/crypto-org-chai...
Near line 452: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...shes returned in some JSON-RPC apis. - [cronos#587](https://github.com/crypto-org-chai...
Near line 453: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx patch cmd recompute eth tx hash. - [cronos#595](https://github.com/crypto-org-chai...
Near line 459: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nd to patch txs post v0.7.0 upgrade. - [cronos#522](https://github.com/crypto-org-chai...
Near line 460: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... the tendermint tx duplicated issue. - [cronos#585](https://github.com/crypto-org-chai...
Near line 474: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ase fee related logic in the code. - [ethermint#817](https://github.com/tharsis/ethermi...
Near line 475: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ogic related to effectiveGasPrice. - [ethermint#822](https://github.com/tharsis/ethermi...
Near line 478: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... tx when block gas limit exceeded. - [cosmos-sdk#10725](https://github.com/cosmos/cosmos...
Near line 486: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e url query parameter in swagger-ui. - [cronos#328](https://github.com/crypto-org-chai...
Near line 487: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...query result when--traceenabled. - [cronos#441](https://github.com/crypto-org-chai...
Near line 494: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ll/329) Fix panic of eth_call on blocks prior to upgrade. - [cronos#340](https://github....
Near line 495: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...eth_call on blocks prior to upgrade. - [cronos#340](https://github.com/crypto-org-chai...
Near line 496: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...t, b) fix data racestraceContext. - [cronos#370](https://github.com/crypto-org-chai...
Near line 497: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...g, add websockets integration tests. - [cronos#378](https://github.com/crypto-org-chai...
Near line 498: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ... add returnValue message on tracing. - [cronos#446](https://github.com/crypto-org-chai...
Near line 618: After ‘it’, use the third-person verb form “upgrades”.
Context: ...org Chain. In addition to that, it also upgrade ethermint to its latest version (v0.5.0...
Additional comments not posted (2)
CHANGELOG.md (2)
21-21: The entry for the RocksDB upgrade is clear and well-documented.
21-21: Correct grammatical error in entry description.- Validate e2ee key when register. + Validate e2ee key when registered.Likely invalid or redundant comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
===========================================
+ Coverage 17.78% 35.86% +18.08%
===========================================
Files 87 136 +49
Lines 5337 9870 +4533
===========================================
+ Hits 949 3540 +2591
- Misses 4278 5934 +1656
- Partials 110 396 +286 |
|
ingest-versiondb-sst fail after https://github.com/facebook/rocksdb/pull/12343/files, and test-versiondb seems green when build fail before |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
versiondb/go.modis excluded by!**/*.modversiondb/go.sumis excluded by!**/*.sum
Files selected for processing (2)
- flake.nix (1 hunks)
- integration_tests/test_versiondb.py (2 hunks)
Additional comments not posted (2)
integration_tests/test_versiondb.py (1)
63-64: Ensure the versiondb directory is empty before ingestion to prevent conflicts.flake.nix (1)
53-67: UpdateddevShellsto includerocksdband related tools, aligning with the new RocksDB version.
the build was cancelled |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
* Problem: rocksdb is out of date Solution: - upgrade to v9.1.1 * tag * changelog * Apply suggestions from code review Signed-off-by: yihuang <[email protected]> * versiondb * fix versiondb integration test * add rocksdb.tools to shell for debugging --------- Signed-off-by: yihuang <[email protected]>
* Problem: rocksdb is out of date Solution: - upgrade to v9.1.1 * tag * changelog * Apply suggestions from code review Signed-off-by: yihuang <[email protected]> * versiondb * fix versiondb integration test * add rocksdb.tools to shell for debugging --------- Signed-off-by: yihuang <[email protected]>
* Problem: rocksdb is out of date (backport #1448) * Problem: rocksdb is out of date Solution: - upgrade to v9.1.1 * tag * changelog * Apply suggestions from code review Signed-off-by: yihuang <[email protected]> * versiondb * fix versiondb integration test * add rocksdb.tools to shell for debugging --------- Signed-off-by: yihuang <[email protected]> * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * lint --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit