-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: recent improvements not backport to v1.2.x #1381
Problem: recent improvements not backport to v1.2.x #1381
Conversation
new version cosmovisor support graceful shutdown Solution: - update cosmovisor - adapt the test case Update CHANGELOG.md Signed-off-by: yihuang <[email protected]>
…-org-chain#1379) Solution: - flush the wal before quit the node, make the rocksdb upgrade smooth. Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> fix flush Signed-off-by: yihuang <[email protected]>
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v1.2.x #1381 +/- ##
==================================================
- Coverage 36.55% 32.91% -3.64%
==================================================
Files 129 125 -4
Lines 9597 9469 -128
==================================================
- Hits 3508 3117 -391
- Misses 5712 6023 +311
+ Partials 377 329 -48
|
Pull request was converted to draft
wait for #1384 |
No breaking changes so far.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)