embed gravity bridge module #11

yihuang · 2021-08-16T03:39:56Z

Closes #9

add gravity module to app
verify address format at application level
fix pystarport config files
~~replace keyring with patched version~~ extracted to separated PR
build orchestrator in nix
add a gravity hook implementation template in cronos module.
add gravity custom gentx command

Testing will be done in another PR.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

Thank you for your code, it's appreciated! :)

tomtau · 2021-08-16T03:42:15Z

app/app.go

+	// AddrLen is the allowed length (in bytes) for an address.
+	//
+	// NOTE: In the SDK, the default value is 255.
+	AddrLen = 20


why changing this? in 0.43, there are 32-byte addresses (e.g. if one uses a different signing algorithm)?

https://github.com/PeggyJV/gravity-bridge/blob/main/module/app/app.go#L104

gravity seems to require this, not sure if it works without it. I guess it need to map any potential cosmos address to ethereum.

PeggyJV/gravity-bridge#143

Opened issue to gravity, I guess it's possible to only do the verification at module level.

codecov · 2021-08-16T03:43:02Z

Codecov Report

❗ No coverage uploaded for pull request base (main@c29fee3). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main     #11   +/-   ##
======================================
  Coverage        ?   3.75%           
======================================
  Files           ?      12           
  Lines           ?    1145           
  Branches        ?       0           
======================================
  Hits            ?      43           
  Misses          ?    1101           
  Partials        ?       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29fee3...106ed59. Read the comment docs.

app/app.go

scripts/devnet.yaml

app/app.go

tomtau · 2021-08-16T07:27:25Z

go.mod

@@ -24,3 +25,5 @@ require (
 replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

 replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1
+
+replace github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76


if we expect more dashes in the chain id, then perhaps using this:
https://github.com/crypto-org-chain/keyring/commits/v1.1.6-fixes which includes @leejw51crypto 's patch for the linux secret service in keyring

extracted the keyring change to standalone PR.

JayT106 · 2021-08-16T15:53:41Z

cmd/cronosd/cmd/gentx.go

+	}
+
+	aTx, err := clientCtx.TxConfig.TxJSONDecoder()(bz)
+	if err != nil {


might just return aTx, err directly instead of check err here.

fixed, thanks

JayT106 · 2021-08-16T16:03:45Z

scripts/devnet.yaml

@@ -1,5 +1,5 @@
-chainmaind-777:
-  cmd: ./build/ethermintd
+cronos-777:


missing d?

hmm, since it's chain id here, maybe we shouldn't add the d, I removed the d in the other chain-ids.

thomas-nguy · 2021-08-18T02:13:19Z

nix/sources.json

@@ -11,6 +11,19 @@
        "url": "https://github.com/tweag/gomod2nix/archive/67f22dd738d092c6ba88e420350ada0ed4992ae8.tar.gz",
        "url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz"
    },
+    "gravity-bridge": {
+        "branch": "main",
+        "description": "A CosmosSDK application for moving assets on and off of EVM based, POW chains",


gravity bridge supports only Cosmos <-> Ethereum at the moment

I think it means transfer to and from EVM chain?

yihuang · 2021-08-18T11:00:59Z

The embed on the cosmos side seems fine, I've managed call set-delegate-keys and deployed gravity contract successfully. The only issue is the address derivation in orchestrator need to use eth style.

In the newer commit I changed the gentx command back to the one from cosmos-sdk, the reason is:

it works with existing tools like pystarport
there is standalone set-delegate-keys command, we can call that after cosmos network is up and running

I also added scripts to help to setup gravity locally, the procedure is roughly like this:

start up cronos network as usual: pystarport serve --config scripts/devnet.yaml
in another terminal run: ./scripts/set-delegate-keys.sh, it'll add and initialize the delegator keys.

clone gravity bridge repo and enter solidity directory

start ethereum network: npm run evm
build gravity contract: npm run typechain

deploy gravity contract, run:

npx ts-node contract-deployer.ts \
  --cosmos-node="http://localhost:26657" \
  --eth-node="http://localhost:8545" \
  --eth-privkey="0xb1bab011e03a9862664706fc3bbaa1b16651528e5f0e7fbfcbfdd8be302a13e7" \
  --contract=./artifacts/contracts/Gravity.sol/Gravity.json \
  --test-mode=true

send some ether to the validator ethereum accounts

start orchestrator

use this branch: https://github.com/yihuang/gravity-bridge/tree/ethermint/orchestrator
build with cargo build --features ethermint

orchestrator --cosmos-phrase="mnemonic words" --ethereum-key=$ETH_ADDR --cosmos-grpc=http://localhost:26653 --address-prefix=eth --ethereum-rpc=http://localhost:8545 --fees=basetcro --contract-address=0xB48095a68501bC157654d338ce86fdaEF4071B24

Closes #9 - add gravity module to app - verify address format at application level - fix pystarport config files - build orchestrator in nix - add a gravity hook implementation template in cronos module - add gravity custom gentx command fix chain id and err handling code add eth_keys command

since we can always do set-delegate-keys later

yihuang · 2021-08-20T02:09:30Z

Simulation test succeed, the module embedding itself should be good, I'm merging this one now.
Orchestrator almost runs, there are still some errors need to investigate, will do that integration test in another PR.
PeggyJV/gravity-bridge#150

yihuang requested review from calvinaco, leejw51crypto, thomas-nguy and tomtau as code owners August 16, 2021 03:39

yihuang marked this pull request as draft August 16, 2021 03:40

yihuang changed the title ~~embed gravity bridge~~ embed gravity bridge module Aug 16, 2021

tomtau requested a review from devashishdxt August 16, 2021 03:41

tomtau reviewed Aug 16, 2021

View reviewed changes

thomas-nguy reviewed Aug 16, 2021

View reviewed changes

app/app.go Show resolved Hide resolved

thomas-nguy reviewed Aug 16, 2021

View reviewed changes

scripts/devnet.yaml Show resolved Hide resolved

yihuang commented Aug 16, 2021

View reviewed changes

app/app.go Outdated Show resolved Hide resolved

yihuang force-pushed the gravity branch 4 times, most recently from 8881053 to 875eb01 Compare August 16, 2021 06:41

yihuang marked this pull request as ready for review August 16, 2021 07:14

yihuang requested a review from JayT106 as a code owner August 16, 2021 07:14

yihuang requested review from tomtau and thomas-nguy August 16, 2021 07:19

tomtau reviewed Aug 16, 2021

View reviewed changes

JayT106 reviewed Aug 16, 2021

View reviewed changes

yihuang force-pushed the gravity branch 2 times, most recently from 263e287 to 0c345a1 Compare August 17, 2021 04:57

thomas-nguy reviewed Aug 18, 2021

View reviewed changes

thomas-nguy approved these changes Aug 18, 2021

View reviewed changes

yihuang added 2 commits August 19, 2021 19:04

better to keep the sdk compatible gentx command

a598bc3

since we can always do set-delegate-keys later

add tool to sign validator msg

84a2376

yihuang force-pushed the gravity branch from 057c9ad to 84a2376 Compare August 19, 2021 12:29

yihuang added 4 commits August 19, 2021 20:29

update chain-id

c600716

fix keeper initialization order

2870161

build patched orchestrator

1733fd0

orchestrator support EthAccount

297fe70

fix changelog order

106ed59

yihuang merged commit 1b05e10 into crypto-org-chain:main Aug 20, 2021

yihuang deleted the gravity branch August 20, 2021 02:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

embed gravity bridge module #11

embed gravity bridge module #11

yihuang commented Aug 16, 2021 •

edited

Loading

tomtau Aug 16, 2021

yihuang Aug 16, 2021

yihuang Aug 16, 2021

codecov bot commented Aug 16, 2021 •

edited

Loading

tomtau Aug 16, 2021

yihuang Aug 16, 2021

JayT106 Aug 16, 2021

yihuang Aug 17, 2021 •

edited

Loading

JayT106 Aug 16, 2021

yihuang Aug 17, 2021

thomas-nguy Aug 18, 2021

yihuang Aug 18, 2021

yihuang commented Aug 18, 2021 •

edited

Loading

yihuang commented Aug 20, 2021 •

edited

Loading

embed gravity bridge module #11

embed gravity bridge module #11

Conversation

yihuang commented Aug 16, 2021 • edited Loading

PR Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Aug 16, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yihuang Aug 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yihuang commented Aug 18, 2021 • edited Loading

yihuang commented Aug 20, 2021 • edited Loading

yihuang commented Aug 16, 2021 •

edited

Loading

codecov bot commented Aug 16, 2021 •

edited

Loading

yihuang Aug 17, 2021 •

edited

Loading

yihuang commented Aug 18, 2021 •

edited

Loading

yihuang commented Aug 20, 2021 •

edited

Loading