Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Ethermint market fee is not enabled #102

Closed
thomas-nguy opened this issue Sep 24, 2021 · 4 comments
Closed

Problem: Ethermint market fee is not enabled #102

thomas-nguy opened this issue Sep 24, 2021 · 4 comments
Assignees
@yihuang
Labels
documentation Improvements or additions to documentation evm This issue or PR is related to EVM help wanted Extra attention is needed high priority

Comments

@thomas-nguy
Copy link
Collaborator

We need to add the module in app.go

However atm the market fee does not have any consequences on ethermint, we can probably wait next ethermint version before enable it
@yihuang yihuang self-assigned this Oct 6, 2021
yihuang added a commit to yihuang/cronos that referenced this issue Oct 6, 2021
@yihuang
Problem: recent version of go-ethereum is not used
f7adc06 
Closes: crypto-org-chain#142 crypto-org-chain#102

Solution:
- update to ethermint's recent main branch
- add feemarket module
@yihuang yihuang mentioned this issue Oct 6, 2021
Closed
13 tasks
yihuang added a commit to yihuang/cronos that referenced this issue Oct 11, 2021
@yihuang
Problem: recent version of go-ethereum is not used
4ad8923 
Closes: crypto-org-chain#142 crypto-org-chain#102

Solution:
- update to ethermint's recent main branch
- add feemarket module

changelog
yihuang added a commit to yihuang/cronos that referenced this issue Oct 11, 2021
@yihuang
Problem: recent version of go-ethereum is not used
09edb13 
Closes: crypto-org-chain#142 crypto-org-chain#102

Solution:
- update to ethermint's recent main branch
- add feemarket module

changelog
@tomtau tomtau changed the title Problem: Ethermint market fee is not enable Problem: Ethermint market fee is not enabled Oct 28, 2021
@tomtau tomtau added documentation Improvements or additions to documentation evm This issue or PR is related to EVM help wanted Extra attention is needed high priority labels Oct 28, 2021
@tomtau
Copy link
Contributor

tomtau commented Oct 28, 2021

related evmos/ethermint#654

@tomtau
Copy link
Contributor

tomtau commented Oct 28, 2021

I guess before it's added, it'd be good to have ADR to outline how this is going to be added on the live network (upgrade handler + some network param changes for EVM?)

@thomas-nguy
Copy link
Collaborator Author

thomas-nguy commented Oct 29, 2021 •
edited
Loading

I think the initial plan is to disable the market fee but "support EIP-1559" by defining a never changing "base fee".

This could be achieve by adding the x/feemarket module and configuring to "no_base_fee" to "true"

TBC

@yihuang
Copy link
Collaborator

yihuang commented Dec 20, 2021

feemarket module is added to main now.

@yihuang yihuang closed this as completed Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihuang yihuang

Labels
documentation Improvements or additions to documentation evm This issue or PR is related to EVM help wanted Extra attention is needed high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yihuang @tomtau @thomas-nguy