forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: mempool iteration is not thread safe #699
Merged
yihuang
merged 8 commits into
crypto-org-chain:release/v0.50.x
from
yihuang:release/v0.50.x
Sep 2, 2024
Merged
Problem: mempool iteration is not thread safe #699
yihuang
merged 8 commits into
crypto-org-chain:release/v0.50.x
from
yihuang:release/v0.50.x
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: cosmos#675 Solution: - hold the lock during iteration
yihuang
commented
Aug 27, 2024
Signed-off-by: yihuang <[email protected]>
SenderNonceMempool seems still have issue |
what issue? |
no now, error from cb is handled |
mmsqe
approved these changes
Aug 30, 2024
yihuang
commented
Sep 2, 2024
Signed-off-by: yihuang <[email protected]>
yihuang
merged commit Sep 2, 2024
535413d
into
crypto-org-chain:release/v0.50.x
40 of 44 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #675
Solution:
A different approach than #681
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...