Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: mempool don't respect gas wanted returned by ante handler #507

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jun 26, 2024

Solution:

  • support custom gas wanted in mempool

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Solution:
- support custom gas wanted in mempool
@yihuang yihuang requested a review from mmsqe June 26, 2024 02:46
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems also need align ProcessProposal totalTxGas check

@yihuang
Copy link
Collaborator Author

yihuang commented Jun 26, 2024

seems also need align ProcessProposal totalTxGas check

good catch, fixed

types/mempool/mempool.go Outdated Show resolved Hide resolved
@mmsqe mmsqe enabled auto-merge (squash) June 26, 2024 03:53
@mmsqe mmsqe merged commit 36295f0 into crypto-org-chain:release/v0.50.x Jun 26, 2024
41 of 44 checks passed
@yihuang yihuang deleted the release/v0.50.x branch June 26, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants