Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: ibc-go is not upgraded to v5.0.0 #869

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Problem: ibc-go is not upgraded to v5.0.0 #869

merged 2 commits into from
Sep 29, 2022

Conversation

devashishdxt
Copy link
Collaborator

Solution: Upgrade ibc-go to v5.0.0

Solution: Upgrade ibc-go to v5.0.0
@devashishdxt devashishdxt requested a review from a team as a code owner September 29, 2022 01:34
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #869 (4bfc982) into master (8514670) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
+ Coverage   16.26%   16.29%   +0.03%     
==========================================
  Files         117      117              
  Lines       14813    14791      -22     
==========================================
+ Hits         2409     2410       +1     
+ Misses      11913    11888      -25     
- Partials      491      493       +2     
Flag Coverage Δ
integration_tests 13.75% <ø> (+<0.01%) ⬆️
unit_tests 6.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 23.52% <ø> (+2.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tomtau
Copy link
Contributor

tomtau commented Sep 29, 2022

/runsim

@github-actions
Copy link

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also a lot of patches on 0.46.x branch of SDK, but I guess we'll want to update after there's a 0.46.2 (given the current one still doesn't have the gRPC nil fix)

@github-actions
Copy link

/runsim simulation test has succeeded 🎉
Can further check here

@tomtau tomtau merged commit 02455a4 into master Sep 29, 2022
@devashishdxt devashishdxt deleted the ibc-go-v5 branch September 29, 2022 04:16
devashishdxt added a commit to devashishdxt/chain-main that referenced this pull request Sep 29, 2022
tomtau pushed a commit that referenced this pull request Sep 29, 2022
Solution: Upgrade ibc-go to v5.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants