Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Fee middleware is not enabled for ICA module #834

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Problem: Fee middleware is not enabled for ICA module #834

merged 2 commits into from
Aug 12, 2022

Conversation

devashishdxt
Copy link
Collaborator

Solution: Enable fee middleware for ICA module

@devashishdxt
Problem: Fee middleware is not enabled for ICA module
5b2472b 
Solution: Enable fee middleware for ICA module
@devashishdxt devashishdxt requested a review from a team as a code owner August 12, 2022 01:34
@devashishdxt
Copy link
Collaborator Author

/runsim

@github-actions
Copy link

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

@codecov
Copy link

codecov bot commented Aug 12, 2022 •
edited
Loading

Codecov Report

Merging #834 (c7efa24) into master (033b9c1) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #834      +/-   ##
==========================================
+ Coverage   20.37%   20.48%   +0.11%     
==========================================
  Files          99       99              
  Lines       11273    11231      -42     
==========================================
+ Hits         2297     2301       +4     
+ Misses       8492     8446      -46     
  Partials      484      484
Flag Coverage Δ
integration_tests 18.20% <ø> (+0.03%) ⬆️
unit_tests 6.98% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 37.36% <0.00%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tomtau
tomtau approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it work now? there's a fail on the ibc integration test: https://github.com/crypto-org-chain/chain-main/runs/7798690698?check_suite_focus=true

@github-actions
Copy link

✅ /runsim simulation test has succeeded 🎉
Can further check here

@devashishdxt
Copy link
Collaborator Author

does it work now? there's a fail on the ibc integration test: https://github.com/crypto-org-chain/chain-main/runs/7798690698?check_suite_focus=true

Fixed app wiring. It should work now.

@devashishdxt
Copy link
Collaborator Author

/runsim

@github-actions
Copy link

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

@github-actions
Copy link

✅ /runsim simulation test has succeeded 🎉
Can further check here

@devashishdxt devashishdxt merged commit e77e73a into crypto-org-chain:master Aug 12, 2022
@devashishdxt devashishdxt deleted the fee-middleware branch August 12, 2022 05:51
devashishdxt added a commit to devashishdxt/chain-main that referenced this pull request Aug 12, 2022
@devashishdxt
Problem: Fee middleware is not enabled for ICA module (crypto-org-cha…
7f964ff 
…in#834)

* Problem: Fee middleware is not enabled for ICA module

Solution: Enable fee middleware for ICA module

* Fix app wiring
tomtau pushed a commit that referenced this pull request Aug 12, 2022
@devashishdxt @tomtau
Problem: Fee middleware is not enabled for ICA module (#834)
6c7ede3 
* Problem: Fee middleware is not enabled for ICA module

Solution: Enable fee middleware for ICA module

* Fix app wiring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devashishdxt @tomtau