-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: cosmos-sdk
and ibc-go
are not upgraded to latest versions
#803
Problem: cosmos-sdk
and ibc-go
are not upgraded to latest versions
#803
Conversation
Solution: Upgraded `cosmos-sdk` to `v0.45.6` and `ibc-go` to `v4.0.0-rc0`. Fixes crypto-org-chain#801. Fixes crypto-org-chain#802. Note: There is an indirect dependency of `ibc-go/v3` because we're using `wasmd` and later replacing with our own fork. ``` $ go mod why -m github.com/cosmos/ibc-go/v3 github.com/crypto-org-chain/chain-main/v4/app github.com/CosmWasm/wasmd/x/wasm/keeper github.com/CosmWasm/wasmd/x/wasm/keeper.test github.com/CosmWasm/wasmd/app github.com/cosmos/interchain-accounts/x/inter-tx/keeper github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/keeper ```
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
- Coverage 18.28% 7.13% -11.16%
==========================================
Files 98 46 -52
Lines 10695 8419 -2276
==========================================
- Hits 1956 601 -1355
+ Misses 8290 7728 -562
+ Partials 449 90 -359
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems the integration tests are broken -- e.g. CLI args for staking changed --moniker
to --new-moniker
?
Created a PR in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should Nixpkgs be upgraded as well: crypto-org-chain/cronos#573 (comment) ?
Created an issue for this: #804 |
crypto-org-chain#803) * Update cosmos-sdk submodule * Problem: `cosmos-sdk` and `ibc-go` are not upgraded to latest versions Solution: Upgraded `cosmos-sdk` to `v0.45.6` and `ibc-go` to `v4.0.0-rc0`. Fixes crypto-org-chain#801. Fixes crypto-org-chain#802. Note: There is an indirect dependency of `ibc-go/v3` because we're using `wasmd` and later replacing with our own fork. ``` $ go mod why -m github.com/cosmos/ibc-go/v3 github.com/crypto-org-chain/chain-main/v4/app github.com/CosmWasm/wasmd/x/wasm/keeper github.com/CosmWasm/wasmd/x/wasm/keeper.test github.com/CosmWasm/wasmd/app github.com/cosmos/interchain-accounts/x/inter-tx/keeper github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/keeper ``` * Update go version in github workflows * Upgrade golangci-lint version and explicitly setup-go as required by golangci-lint * Fix staking tests * Format python code
#803) * Update cosmos-sdk submodule * Problem: `cosmos-sdk` and `ibc-go` are not upgraded to latest versions Solution: Upgraded `cosmos-sdk` to `v0.45.6` and `ibc-go` to `v4.0.0-rc0`. Fixes #801. Fixes #802. Note: There is an indirect dependency of `ibc-go/v3` because we're using `wasmd` and later replacing with our own fork. ``` $ go mod why -m github.com/cosmos/ibc-go/v3 github.com/crypto-org-chain/chain-main/v4/app github.com/CosmWasm/wasmd/x/wasm/keeper github.com/CosmWasm/wasmd/x/wasm/keeper.test github.com/CosmWasm/wasmd/app github.com/cosmos/interchain-accounts/x/inter-tx/keeper github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/keeper ``` * Update go version in github workflows * Upgrade golangci-lint version and explicitly setup-go as required by golangci-lint * Fix staking tests * Format python code
Solution: Upgraded
cosmos-sdk
tov0.45.6
andibc-go
tov4.0.0-rc0
. Fixes #801. Fixes #802.Note: There is an indirect dependency of
ibc-go/v3
because we're usingwasmd
and later replacing with our own fork.