Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cosmos-sdk and ibc-go are not upgraded to latest versions #803

Merged
merged 6 commits into from
Jul 7, 2022

Conversation

devashishdxt
Copy link
Collaborator

Solution: Upgraded cosmos-sdk to v0.45.6 and ibc-go to v4.0.0-rc0. Fixes #801. Fixes #802.

Note: There is an indirect dependency of ibc-go/v3 because we're using wasmd and later replacing with our own fork.

$ go mod why -m github.com/cosmos/ibc-go/v3

github.com/crypto-org-chain/chain-main/v4/app
github.com/CosmWasm/wasmd/x/wasm/keeper
github.com/CosmWasm/wasmd/x/wasm/keeper.test
github.com/CosmWasm/wasmd/app
github.com/cosmos/interchain-accounts/x/inter-tx/keeper
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/keeper

Solution: Upgraded `cosmos-sdk` to `v0.45.6` and `ibc-go` to `v4.0.0-rc0`. Fixes crypto-org-chain#801. Fixes crypto-org-chain#802.

Note: There is an indirect dependency of `ibc-go/v3` because we're using `wasmd` and later replacing with our own fork.

```
$ go mod why -m github.com/cosmos/ibc-go/v3

github.com/crypto-org-chain/chain-main/v4/app
github.com/CosmWasm/wasmd/x/wasm/keeper
github.com/CosmWasm/wasmd/x/wasm/keeper.test
github.com/CosmWasm/wasmd/app
github.com/cosmos/interchain-accounts/x/inter-tx/keeper
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/keeper
```
@devashishdxt devashishdxt requested a review from a team as a code owner July 6, 2022 02:30
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #803 (1eb82d9) into master (0b3777d) will decrease coverage by 11.15%.
The diff coverage is 0.00%.

❗ Current head 1eb82d9 differs from pull request most recent head 9ca726c. Consider uploading reports for the commit 9ca726c to get more accurate results

@@            Coverage Diff             @@
##           master    #803       +/-   ##
==========================================
- Coverage   18.28%   7.13%   -11.16%     
==========================================
  Files          98      46       -52     
  Lines       10695    8419     -2276     
==========================================
- Hits         1956     601     -1355     
+ Misses       8290    7728      -562     
+ Partials      449      90      -359     
Flag Coverage Δ
integration_tests ?
unit_tests 7.13% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/ante.go 0.00% <ø> (-50.00%) ⬇️
app/app.go 0.48% <ø> (-66.18%) ⬇️
x/icaauth/types/message_register_account.go 25.00% <0.00%> (+25.00%) ⬆️
x/icaauth/types/tx.pb.go 0.80% <0.00%> (-1.75%) ⬇️
app/encoding.go 0.00% <0.00%> (-100.00%) ⬇️
x/icaauth/types/codec.go 0.00% <0.00%> (-100.00%) ⬇️
x/nft/keeper/msg_server.go 0.84% <0.00%> (-79.00%) ⬇️
x/nft/types/keys.go 0.00% <0.00%> (-58.98%) ⬇️
x/nft/types/codec.go 32.25% <0.00%> (-58.07%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b3777d...9ca726c. Read the comment docs.

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the integration tests are broken -- e.g. CLI args for staking changed --moniker to --new-moniker?

@devashishdxt
Copy link
Collaborator Author

it seems the integration tests are broken -- e.g. CLI args for staking changed --moniker to --new-moniker?

Created a PR in pystarport: crypto-com/pystarport#61

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should Nixpkgs be upgraded as well: crypto-org-chain/cronos#573 (comment) ?

@devashishdxt
Copy link
Collaborator Author

should Nixpkgs be upgraded as well: crypto-org-chain/cronos#573 (comment) ?

Created an issue for this: #804

@devashishdxt devashishdxt merged commit 8940fb0 into crypto-org-chain:master Jul 7, 2022
@devashishdxt devashishdxt deleted the dep-upgrade branch July 7, 2022 07:29
devashishdxt added a commit to devashishdxt/chain-main that referenced this pull request Jul 15, 2022
crypto-org-chain#803)

* Update cosmos-sdk submodule

* Problem: `cosmos-sdk` and `ibc-go` are not upgraded to latest versions

Solution: Upgraded `cosmos-sdk` to `v0.45.6` and `ibc-go` to `v4.0.0-rc0`. Fixes crypto-org-chain#801. Fixes crypto-org-chain#802.

Note: There is an indirect dependency of `ibc-go/v3` because we're using `wasmd` and later replacing with our own fork.

```
$ go mod why -m github.com/cosmos/ibc-go/v3

github.com/crypto-org-chain/chain-main/v4/app
github.com/CosmWasm/wasmd/x/wasm/keeper
github.com/CosmWasm/wasmd/x/wasm/keeper.test
github.com/CosmWasm/wasmd/app
github.com/cosmos/interchain-accounts/x/inter-tx/keeper
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/keeper
```

* Update go version in github workflows

* Upgrade golangci-lint version and explicitly setup-go as required by golangci-lint

* Fix staking tests

* Format python code
devashishdxt added a commit that referenced this pull request Jul 15, 2022
#803)

* Update cosmos-sdk submodule

* Problem: `cosmos-sdk` and `ibc-go` are not upgraded to latest versions

Solution: Upgraded `cosmos-sdk` to `v0.45.6` and `ibc-go` to `v4.0.0-rc0`. Fixes #801. Fixes #802.

Note: There is an indirect dependency of `ibc-go/v3` because we're using `wasmd` and later replacing with our own fork.

```
$ go mod why -m github.com/cosmos/ibc-go/v3

github.com/crypto-org-chain/chain-main/v4/app
github.com/CosmWasm/wasmd/x/wasm/keeper
github.com/CosmWasm/wasmd/x/wasm/keeper.test
github.com/CosmWasm/wasmd/app
github.com/cosmos/interchain-accounts/x/inter-tx/keeper
github.com/cosmos/ibc-go/v3/modules/apps/27-interchain-accounts/controller/keeper
```

* Update go version in github workflows

* Upgrade golangci-lint version and explicitly setup-go as required by golangci-lint

* Fix staking tests

* Format python code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: ibc-go is not upgraded to 4.0.0-rc0 Problem: cosmos-sdk is not upgraded to v0.45.6
2 participants