Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: go1.18 on nix don't work on macos #799

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jul 4, 2022

Solution:

  • use go1.17 on macos for now

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- use go1.17 on macos for now
@yihuang yihuang requested a review from a team as a code owner July 4, 2022 06:47
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #799 (d7681e8) into master (f1bc423) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   18.28%   18.28%           
=======================================
  Files          98       98           
  Lines       10695    10695           
=======================================
  Hits         1956     1956           
  Misses       8290     8290           
  Partials      449      449           
Flag Coverage Δ
integration_tests 18.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1bc423...d7681e8. Read the comment docs.

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just use 1.17 for all?

@tomtau tomtau merged commit 0b3777d into crypto-org-chain:master Jul 4, 2022
@yihuang yihuang deleted the build-on-mac branch July 5, 2022 02:08
devashishdxt pushed a commit to devashishdxt/chain-main that referenced this pull request Jul 15, 2022
devashishdxt pushed a commit that referenced this pull request Jul 15, 2022
Solution:
- use go1.17 on macos for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants