Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: outdated CodeQL scanning pipeline (fixes #772) #773

Merged
merged 1 commit into from
May 24, 2022

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented May 20, 2022

Solution:

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #773 (56ef83d) into master (12edc52) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 56ef83d differs from pull request most recent head 37f732a. Consider uploading reports for the commit 37f732a to get more accurate results

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   17.77%   17.65%   -0.13%     
==========================================
  Files          99       98       -1     
  Lines       10630    10836     +206     
==========================================
+ Hits         1890     1913      +23     
- Misses       8300     8477     +177     
- Partials      440      446       +6     
Flag Coverage Δ
integration_tests 17.65% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/nft/keeper/querier.go 7.51% <0.00%> (-7.20%) ⬇️
app/app.go 55.71% <0.00%> (-6.06%) ⬇️
x/nft/types/validation.go 35.71% <0.00%> (-2.75%) ⬇️
app/state.go 0.00% <0.00%> (ø)
app/export.go 0.00% <0.00%> (ø)
x/nft/simulation/decoder.go 0.00% <0.00%> (ø)
x/nft/simulation/operations.go 0.00% <0.00%> (ø)
x/nft/types/denom.go
x/nft/types/events.go
app/docs/statik/statik.go 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12edc52...37f732a. Read the comment docs.

Solution:
- updated the GH action pipeline
- removed Nondeterministic.ql
(the more refined version is now contained in the query pack:
https://github.com/crypto-com/cosmos-sdk-codeql/blob/main/src/map-iteration.ql )
@tomtau tomtau merged commit 5a64382 into crypto-org-chain:master May 24, 2022
@tomtau tomtau deleted the fix/codelq branch May 24, 2022 01:13
devashishdxt pushed a commit to devashishdxt/chain-main that referenced this pull request Jul 15, 2022
… (crypto-org-chain#773)

Solution:
- updated the GH action pipeline
- removed Nondeterministic.ql
(the more refined version is now contained in the query pack:
https://github.com/crypto-com/cosmos-sdk-codeql/blob/main/src/map-iteration.ql )
devashishdxt pushed a commit that referenced this pull request Jul 15, 2022
Solution:
- updated the GH action pipeline
- removed Nondeterministic.ql
(the more refined version is now contained in the query pack:
https://github.com/crypto-com/cosmos-sdk-codeql/blob/main/src/map-iteration.ql )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants