Problem: test_sign_offline fails in 0.44 (fix #644) #761
Conversation
linfeng-crypto
requested review from
tomtau,
devashishdxt,
calvinaco and
yihuang
as code owners
linfeng-crypto
changed the title
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=======================================
Coverage 17.77% 17.77%
=======================================
Files 99 99
Lines 10630 10630
=======================================
Hits 1890 1890
Misses 8300 8300
Partials 440 440
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| chainlibpy = "^1.0.0" | ||
| # chainlibpy use version 0.2.3 pystarport | ||
| pystarport = "=0.2.3" | ||
| chainlibpy = { git = "https://github.com/crypto-org-chain/chainlibpy.git", branch = "master" } |
There was a problem hiding this comment.
can this use the version from PyPI?
There was a problem hiding this comment.
I think we need to release a new version of chainlibpy.
| alice_addr = cluster.address("signer1") | ||
| cluster.transfer(alice_addr, offline_addr, "100cro") | ||
| wait_for_new_blocks(cluster, 2) | ||
| assert cluster.balance(offline_addr) > 0 |
There was a problem hiding this comment.
should this assert the amount it was transferred in?
| alice_addr = cluster.address("signer1") | ||
| cluster.transfer(alice_addr, offline_addr, "100cro") | ||
| wait_for_new_blocks(cluster, 2) | ||
| assert cluster.balance(offline_addr) > 0 |
There was a problem hiding this comment.
should this assert the amount it was transferred in?
|
good for @macong-cdc to review this, given this is based on #705 |
|
LGTM. |
|
@macong-cdc @linfeng-crypto can 2.2.0 for chainlibpy be released? |
integration_tests/pyproject.toml
Outdated
| chainlibpy = "^1.0.0" | ||
| # chainlibpy use version 0.2.3 pystarport | ||
| pystarport = "=0.2.3" | ||
| chainlibpy = "2.2.0" |
There was a problem hiding this comment.
this version doesn't appear to be released on PyPI yet: https://pypi.org/project/chainlibpy/
+ the poetry.lock wasn't updated
linfeng-crypto
force-pushed
the
sign-offline
branch
from
9c72e5d
to
8cf05ac
Compare
There was a problem hiding this comment.
ok by @macong-cdc -- a new version of chainlibpy can be released and the test code can be migrated to it in a separate PR
tomtau
changed the title
No description provided.