Problem: Adding chain-maind keys will not be actually stored in disk …

[leejw51crypto]

Solution: add decoding _hexcode in service name fetched

[codecov]

Codecov Report

Merging #441 (d0a044a) into master (f8f0ba5) will increase coverage by 3.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   17.00%   20.20%   +3.20%     
==========================================
  Files          55       56       +1     
  Lines        8399     8768     +369     
==========================================
+ Hits         1428     1772     +344     
- Misses       6572     6574       +2     
- Partials      399      422      +23     

Flag	Coverage Δ
integration_tests	17.98% <ø> (+0.98%)	⬆️
unit_tests	11.48% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app/app.go	18.38% <0.00%> (-81.62%)	⬇️
x/subscription/types/codec.go	0.00% <0.00%> (-5.89%)	⬇️
x/supply/client/rest/query.go	3.40% <0.00%> (-4.60%)	⬇️
x/subscription/types/msgs.go	5.79% <0.00%> (-1.82%)	⬇️
app/test_helpers.go	0.00% <0.00%> (ø)
x/subscription/types/params.go	0.00% <0.00%> (ø)
x/chainmain/types/types.go
x/chainmain/types/keys.go	65.62% <0.00%> (ø)
config/config.go	55.55% <0.00%> (ø)
x/subscription/keeper/msg_server.go	32.03% <0.00%> (+0.81%)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e5245...d0a044a. Read the comment docs.

[leejw51crypto]

keyring pr is here
https://github.com/99designs/keyring/pull/83/files

keyring is stored here in linux)
$HOME/.local/share/keyrings

[JayT106]

I see some of the modules been removed from the go.sum. How do they relate to the fixes?
For the keyring dependency, is it better to merge @leejw51crypto 's fixes to the upstream repo first and then use it? (Not sure how urgent is the fixes)

[tomtau]

yeah, may be better to wait for the upstream -- it seems it's maintained

[leejw51crypto]

ok, got it
because it's simple fix, can be merged shortly.

[leejw51crypto]

I see some of the modules been removed from the go.sum. How do they relate to the fixes?
For the keyring dependency, is it better to merge @leejw51crypto 's fixes to the upstream repo first and then use it? (Not sure how urgent is the fixes)

i ran "go mod tidy" to check mod

this is urgent issue, because in linux, keyring is not usable by default.
users of linux cli will encounter this issue.

[tomtau]

there are some conflicts with the latest master.

it seems upstream may take time -- I've forked the repo with the fix here, so the go.mod can be updated to this one: https://github.com/crypto-org-chain/keyring/tree/gnome for the moment

[leejw51crypto]

ok, i'll rebase with the latest
also, writing unit test for keyring

[leejw51crypto]

inspecting integration test failures

[leejw51crypto]

fixed, increase waiting time twice :-)

[matias904]

1150696