Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem:(Fix #1) Outdated content #38

Merged
merged 19 commits into from
Nov 23, 2020
Merged

Problem:(Fix #1) Outdated content #38

merged 19 commits into from
Nov 23, 2020

Conversation

lezzokafka
Copy link
Collaborator

@lezzokafka lezzokafka commented Nov 3, 2020

Check list:

  • Overview on Crypto.com Chain ;
  • Architecture;
  • Genesis file explained ;
  • Network parameters explained ;
  • Chain ID;
  • Account prefixes.

Cosmos SDK modules (#11)

  • bank
  • distribution
  • gov
  • mint
  • slashing
  • staking

  • Nav bar

#34 will be resolved in a separated task

@lezzokafka lezzokafka marked this pull request as ready for review November 13, 2020 07:30
@lezzokafka
Copy link
Collaborator Author

/staging

@lezzokafka lezzokafka changed the title [WIP] Problem: Outdated content Problem:(Fix #1) Outdated content Nov 16, 2020
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all right -- the intro sections may be shortened / synced up with whatever is in the business white paper

Comment on lines 8 to 11
Crypto.com Chain is open to the public to join, participate and scrutinise related transactions. We do not expect that, for example, mobile clients will be able to perform heavy-lifting tasks and have a reliable always-online network connection. For that reason, there are two different types of nodes are responsible for various duties:

- Validator (Council Node), responsible for validating and committing new blocks to the blockchain; and
- Community Node (Full node), responsible for fetching the blockchain data and serve it upon the client's request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does introducing special terminology help anything? just use "full node" and "validator"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to "full node" and "validator"


Crypto.com chain uses the Bech32 address format wherever users must handle binary data. Bech32 encoding provides robust integrity checks on data and the human readable part(HRP) that provides contextual hints that can assist UI developers with providing informative error messages. Specifically, we have the following HRP prefix for different addresses types in the mainnet:

| | Address bech32 Prefix | Pubkey bech32 Prefix |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pubkey bech32 representation may be removed in the SDK release

Copy link
Collaborator Author

@lezzokafka lezzokafka Nov 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will remove the Pubkey bech32 Prefix here and keep an eye on cosmos/cosmos-sdk#7447.

--
Removed

- Not friendly to crypto first timers; and
- Rarely supported beyond their own blockchain;

Accordingly, we propose Crypto.com Chain, the next generation decentralized mobile payment protocol, the most efficient and secure way to pay and be paid in crypto, anywhere, any crypto at little to no cost. Crypto.com Chain will deliver on its vision by developing innovative technology components and processes catered specifically to cryptocurrency payment, while leveraging proven blockchain technology structural design elements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the re-pivoted version still mobile payment-focused? probably sync with business white paper what it says?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned with the business white paper.


Below are all the network parameters for the `distribution` module:

- `community_tax` - The rate of community tax;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in this module description, I guess it'll be good to explain/note why community pool may be non-zero even if the tax rate is zero.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added further details on Community tax.

@@ -0,0 +1,13 @@
# Modules - overview

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devashish recently added "module" for the supply querying, so perhaps good to document that too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I have included the supply module in b9e6333.

be marked as **non-live** and jailed if they fail to successfully sign at least `2000*0.5=1000` blocks in last `2000` blocks.
:::

- Byzantine Faults (Double signing)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the latest tendermint/sdk, there may be one other fault type defined?

@lezzokafka
Copy link
Collaborator Author

/staging

@lezzokafka
Copy link
Collaborator Author

/staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants