fix: pruning don't delete all orphaned nodes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
reviewed
Dec 7, 2022
| @@ -130,12 +130,16 @@ def delete_version(self, v: int) -> int: | |||
| from .diff import diff_tree | |||
|
|
|||
| counter = 0 | |||
| # optimize the case when deleting from the beginning, | |||
| # in that case, the previous version will always be 0. | |||
There was a problem hiding this comment.
so we cant add test for case like version 2 node in version 5, deleted in version 7, del when more than 3 versions diff?
There was a problem hiding this comment.
yeah, we should have more tests for pruning.
mmsqe
reviewed
Dec 7, 2022
| prev_version = self.prev_version(v) or 0 | ||
| root1 = self.get_root_node(v) | ||
| root2 = self.get_root_node(self.next_version(v)) | ||
| for orphaned, _ in diff_tree(self.get, root1, root2): | ||
| for n in orphaned: | ||
| if n.version > prev_version: | ||
| if n.version > prev_version or not self.get_root_hash(n.version): |
There was a problem hiding this comment.
get_root_hash is not in-memory, but we should cache the version information in NodeDB.
mmsqe
approved these changes
Dec 7, 2022
|
closing, not an issue, see: cosmos/iavl#641 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks @cool-develope find the issue.