feat(matchexpressions): expressions can reference target JFR event type IDs #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build_test |
|
Workflow started at 12/6/2024, 3:14:08 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
|
/build_test |
|
Workflow started at 12/6/2024, 3:50:45 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
This was referenced Dec 11, 2024
andrewazores
force-pushed
the
expressions-event-types
branch
from
caaa21b to
3136928
Compare
7 tasks
Josh-Matsuoka
approved these changes
Dec 19, 2024
andrewazores
force-pushed
the
expressions-event-types
branch
from
3136928 to
329fec6
Compare
|
/build_test |
|
Workflow started at 12/19/2024, 4:33:24 PM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainSee #733 (comment)
Related to #727
Related to #548
Description of the change:
See #733 (comment)
Motivation for the change:
Enables the creation of match expressions that evaluate the JFR event types available on a given target JVM. This probably isn't very useful for Stored Credentials, but for Automated Rules it will couple well with #733 , as well as with custom application-level JFR events. It becomes possible to define Automated Rules that use a preset or custom event template containing framework- or application-level events, and only activate on targets where those event types are actually present. For example, a Rule can be created that matches Quarkus applications which have the
quarkus-jfrextension enabled.How to manually test:
./smoketest.bash -Oquarkus-jfrextension, so if these two PRs are combined then the Quarkus-specific events referenced in that comment can be used. Otherwise, an event type ID likejdk.CPULoadcan be used to test the expression evaluation.