Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat(reports): reports sidecar, configurable caching #65

Closed
wants to merge 18 commits into from
Closed

WIP feat(reports): reports sidecar, configurable caching #65

wants to merge 18 commits into from

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 25, 2023

Based on #62
Depends on #62

Reimplements sidecar report generation using a cryostat-reports instance and implements two tiers of caching:

  • in-memory caching using Caffeine caches for both active and archived reports. Active report cache entries expire shortly after write, archived report cache entries expire after a longer time and after read.
  • S3 caching for archived reports. These persist until the source archived recording is deleted through the Cryostat API, and also have an S3 expiration of 1 day after creation.

TODO: after rebasing, the in-memory active recording cache doesn't seem to expire on a timer, it just always returns cached entries.

@andrewazores andrewazores added the feat New feature or request label Aug 25, 2023
@github-actions
Copy link

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant