-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diagnostic): implement diagnostics class with gc invocation operation #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR/issue depends on: |
andrewazores
force-pushed
the
mxbean-invoke
branch
from
September 12, 2024 13:46
d317456
to
c9cf7f8
Compare
7 tasks
andrewazores
force-pushed
the
mxbean-invoke
branch
from
September 12, 2024 13:48
c9cf7f8
to
29cfc18
Compare
This was referenced Sep 24, 2024
andrewazores
force-pushed
the
mxbean-invoke
branch
from
October 1, 2024 16:28
d6b3172
to
c4b0927
Compare
/build_test |
Workflow started at 10/1/2024, 3:44:56 PM. View Actions Run. |
No GraphQL schema changes detected. |
OpenAPI schema change detected: diff --git a/schema/openapi.yaml b/schema/openapi.yaml
index ca6280b..7ccd335 100644
--- a/schema/openapi.yaml
+++ b/schema/openapi.yaml
@@ -649,20 +649,40 @@ info:
name: Cryostat Community
url: https://cryostat.io
description: Cloud-Native JDK Flight Recorder
license:
name: Apache 2.0
url: https://github.com/cryostatio/cryostat/blob/main/LICENSE
title: Cryostat API
version: 4.0.0-snapshot
openapi: 3.0.3
paths:
+ /api/beta/diagnostics/targets/{targetId}/gc:
+ post:
+ parameters:
+ - in: path
+ name: targetId
+ required: true
+ schema:
+ format: int64
+ type: integer
+ responses:
+ "201":
+ description: Created
+ "401":
+ description: Not Authorized
+ "403":
+ description: Not Allowed
+ security:
+ - SecurityScheme: []
+ tags:
+ - Diagnostics
/api/beta/fs/recordings:
get:
responses:
"200":
content:
application/json:
schema:
items:
$ref: '#/components/schemas/ArchivedRecordingDirectory'
type: array
|
Schema changes committed by the CI. |
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #133
Depends on cryostatio/cryostat-core#459
NOTE Since this depends on an addition to-core
, which publishes snapshot builds but for which the CI to do so is currently broken, this cannot be merged until that CI failure is resolved. Otherwise, Cryostat (and the associated upcoming Agent PR) will fail to build and all CI will be failing.Description of the change:
Implements the Agent HTTP delegation side of the MBean operation invocation request, and adds a beta API endpoint which invokes the GC operation on the Agent HTTP or JMX connection to the specified Target JVM.
Motivation for the change:
Combined with the
-core
change and upcoming-agent
and-web
changes, this will allow the user to click a button in the Cryostat UI to send a request to their Target JVM requesting that it perform a garbage collection.How to manually test: