Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(multiarch): improve build times #581

Merged
merged 19 commits into from
Jul 26, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jul 23, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


See #373
Based on #580

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@github-actions github-actions bot added dependent needs-triage Needs thorough attention from code reviewers and removed dependent labels Jul 23, 2024
@andrewazores andrewazores added ci safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Jul 23, 2024
@andrewazores
Copy link
Member Author

In the end, these efforts haven't really helped the build time. This is just trying to add caching, but the caches are not easily preserved between runs, so nothing changes.

pom.xml Outdated Show resolved Hide resolved
@andrewazores
Copy link
Member Author

The last commit should preserve the src/main/webui/.build_cache, which might actually help. I hope so, anyway. On my machine a fresh web-client build (npm deps installed but build cache deleted) takes ~12.5 seconds, whereas a rebuild takes ~2 seconds - probably because it's just spending time verifying things against the cache.

Copy link

@andrewazores andrewazores marked this pull request as ready for review July 25, 2024 15:05
@andrewazores andrewazores requested a review from a team as a code owner July 25, 2024 15:05
@andrewazores andrewazores requested review from aali309 and maxcao13 July 25, 2024 15:06
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 7/25/2024, 11:07:45 AM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat/actions/runs/10096652182

@andrewazores andrewazores requested review from mwangggg and removed request for maxcao13 July 26, 2024 13:30
mwangggg
mwangggg previously approved these changes Jul 26, 2024
@mwangggg
Copy link
Member

oh actually, it might be nice to update the actions to versions that use node20 so there aren't so many deprecation warnings.

@mwangggg
Copy link
Member

looks good now

@andrewazores andrewazores merged commit 52c5862 into cryostatio:main Jul 26, 2024
8 checks passed
@andrewazores andrewazores deleted the ci-fastbuild branch July 26, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants