Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): split up sample applications, selectable using -t #572

Merged
merged 15 commits into from
Jul 19, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jul 19, 2024

  • test(smoketest): split up sample applications, selectable using -t
  • generic https config handling
  • run cert setup/cleanup regardless of quarkus-cryostat-agent loaded
  • fixup! test(smoketest): split up sample applications, selectable using -t
  • clean up using script
  • correct hostname in cert
  • remove restart: without healthcheck
  • add healthcheck

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #403

Description of the change:

Splits up the sample-apps.yml into multiple files under a sample_apps directory. Each file can be selected by name using -t, or else -t all can be used. -t with no argument alone is the same as -t all, so this behaves the same as before.

Motivation for the change:

See #403 - as we add more applications for testing, it's nice to be able to pick and choose which ones to actually deploy, in case a particular test being performed only needs to test some subset of the test applications.

How to manually test:

  1. Check out PR
  2. ./smoketest.bash -h - should provide a comma-separated list of what all the sample application selection options are
  3. ./smoketest.bash -t - should do the same as main
  4. ./smoketest.bash -t all - should do the same as above
  5. ./smoketest.bash -t gameserver - should only deploy the gameserver sample
  6. ./smoketest.bash -t opensearch,quarkus-cryostat-agent - should deploy only the opensearch and quarkus-cryostat-agent samples
  7. ./smoketest.bash -Ak -t opensearch,quarkus-cryostat-agent - should deploy only the opensearch and quarkus-cryostat-agent samples, and quarkus-cryostat-agent and Cryostat itself should not use TLS but should still work
  8. Any other flag combination you care to test

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jul 19, 2024
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Jul 19, 2024
smoketest.bash Show resolved Hide resolved
smoketest.bash Show resolved Hide resolved
smoketest.bash Show resolved Hide resolved
smoketest.bash Outdated Show resolved Hide resolved
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@andrewazores andrewazores force-pushed the smoketest-split-samples branch from d2c2679 to ab53f65 Compare July 19, 2024 21:03
@andrewazores andrewazores merged commit 826f4d0 into cryostatio:main Jul 19, 2024
8 checks passed
@andrewazores andrewazores deleted the smoketest-split-samples branch July 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants