-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(smoketest): split up sample applications, selectable using -t #572
Merged
andrewazores
merged 15 commits into
cryostatio:main
from
andrewazores:smoketest-split-samples
Jul 19, 2024
Merged
test(smoketest): split up sample applications, selectable using -t #572
andrewazores
merged 15 commits into
cryostatio:main
from
andrewazores:smoketest-split-samples
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
Needs thorough attention from code reviewers
label
Jul 19, 2024
andrewazores
removed
the
needs-triage
Needs thorough attention from code reviewers
label
Jul 19, 2024
tthvo
reviewed
Jul 19, 2024
tthvo
reviewed
Jul 19, 2024
tthvo
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
andrewazores
force-pushed
the
smoketest-split-samples
branch
from
July 19, 2024 21:03
d2c2679
to
ab53f65
Compare
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #403
Description of the change:
Splits up the
sample-apps.yml
into multiple files under asample_apps
directory. Each file can be selected by name using-t
, or else-t all
can be used.-t
with no argument alone is the same as-t all
, so this behaves the same as before.Motivation for the change:
See #403 - as we add more applications for testing, it's nice to be able to pick and choose which ones to actually deploy, in case a particular test being performed only needs to test some subset of the test applications.
How to manually test:
./smoketest.bash -h
- should provide a comma-separated list of what all the sample application selection options are./smoketest.bash -t
- should do the same asmain
./smoketest.bash -t all
- should do the same as above./smoketest.bash -t gameserver
- should only deploy the gameserver sample./smoketest.bash -t opensearch,quarkus-cryostat-agent
- should deploy only the opensearch and quarkus-cryostat-agent samples./smoketest.bash -Ak -t opensearch,quarkus-cryostat-agent
- should deploy only the opensearch and quarkus-cryostat-agent samples, and quarkus-cryostat-agent and Cryostat itself should not use TLS but should still work