Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rules): add blocking annotation for rules error #526

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

mwangggg
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #525

@mwangggg mwangggg requested review from ebaron and tthvo June 18, 2024 17:40
@mergify mergify bot added the safe-to-test label Jun 18, 2024
@mwangggg mwangggg requested a review from aali309 June 18, 2024 17:59
@mwangggg mwangggg added the fix label Jun 18, 2024
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@andrewazores
Copy link
Member

/build_test

Copy link

Workflow started at 6/24/2024, 11:25:11 AM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat/actions/runs/9648072764

@andrewazores andrewazores merged commit 0914b94 into cryostatio:main Jun 24, 2024
9 checks passed
mergify bot pushed a commit that referenced this pull request Jun 24, 2024
andrewazores pushed a commit that referenced this pull request Jun 24, 2024
…532)

fix(rules): add blocking annotation for rules error (#526)

(cherry picked from commit 0914b94)

Co-authored-by: Ming Yu Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Quarkus Blocking error in RuleService
5 participants