Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entrypoint): continue startup if TLS cert import fails #475

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented May 23, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #474
See also #462 - if JMX credentials pwfile/usrfile are already created, then the same reproduction steps will also fail because the previous container instance's files are still present but were created by a different container UID and so the new container instance has no access to the existing files

How to test:

  1. Check out and build PR
  2. Copy a TLS cert (ex. https://github.com/andrewazores/vertx-fib-demo/blob/master/src/main/extras/app/resources/vertx-fib-demo.cer) into cryostat3/truststore directory
  3. ./smoketest.bash -O
  4. Wait for Cryostat to come up, then podman restart compose_cryostat_1. Cryostat should successfully restart - before this PR it would repeatedly fail to start due to the TLS cert already having been imported.

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 5/23/2024, 3:40:58 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9213892230

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 5/30/2024, 11:16:54 AM. View Actions Run.

Copy link

No OpenAPI schema changes detected.

Copy link

No GraphQL schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9305006274

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 5/30/2024, 1:31:21 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9306745786

@andrewazores andrewazores force-pushed the certificate-exists branch 3 times, most recently from 58880a2 to 7b23e86 Compare June 3, 2024 19:46
@andrewazores
Copy link
Member Author

@aali309 @mwangggg ping

@andrewazores andrewazores merged commit 4546260 into cryostatio:main Jun 3, 2024
7 checks passed
@andrewazores andrewazores deleted the certificate-exists branch June 3, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cryostat fails to restart if TLS certs have already been imported
2 participants