Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(tls): set up TLS in oauth-proxy config #426

Merged
merged 30 commits into from
Jul 15, 2024
Merged

test(tls): set up TLS in oauth-proxy config #426

merged 30 commits into from
Jul 15, 2024

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Apr 29, 2024 •
edited
Loading

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to: cryostatio/cryostat-agent#141
depends on: cryostatio/cryostat-agent#257

@mwangggg mwangggg requested a review from andrewazores April 29, 2024 16:36
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Apr 29, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@andrewazores andrewazores changed the title draft(oauth-proxy): set up TLS in oauth-proxy config test(tls): set up TLS in oauth-proxy config Apr 29, 2024
@andrewazores andrewazores added test safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Apr 29, 2024
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

5 similar comments
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mwangggg mwangggg marked this pull request as ready for review April 30, 2024 14:38
@mwangggg mwangggg requested a review from a team May 1, 2024 17:49
andrewazores
andrewazores reviewed May 1, 2024
View reviewed changes
smoketest.bash Outdated Show resolved Hide resolved
@andrewazores andrewazores mentioned this pull request May 1, 2024
Closed
7 tasks
andrewazores
andrewazores reviewed May 2, 2024
View reviewed changes
smoketest.bash Outdated Show resolved Hide resolved
@andrewazores
Copy link
Member

Change looks good, just needs a rebase. It depends on cryostatio/cryostat-agent#257 as well, right?

@mwangggg
Copy link
Member Author

mwangggg commented May 3, 2024

yes - I have too many tabs open and accidentally linked the wrong PR

@andrewazores andrewazores merged commit be27d7d into cryostatio:main Jul 15, 2024
8 checks passed
@mwangggg mwangggg deleted the testing-HTTPS branch August 1, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@mergify mergify[bot] mergify[bot] left review comments

Assignees
No one assigned
Labels
safe-to-test test
Projects
4.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mwangggg @andrewazores