Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matchexpressions): correct endpoint case for JSON ID request filter #356

Merged

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #329

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores
Copy link
Member Author

/build_test

@andrewazores andrewazores requested review from aali309 and mwangggg April 8, 2024 16:07
Copy link

github-actions bot commented Apr 8, 2024

Workflow started at 4/8/2024, 12:07:28 PM. View Actions Run.

Copy link

github-actions bot commented Apr 8, 2024

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/8603254086

Copy link

github-actions bot commented Apr 8, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Apr 8, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8603254086

do not allow IDs in rule creation POSTS, but do allow in modification PATCHes - the ID field will be ignored here anyway
@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Apr 8, 2024

Workflow started at 4/8/2024, 1:16:37 PM. View Actions Run.

Copy link

github-actions bot commented Apr 8, 2024

CI build and push: At least one test failed ❌ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8604109482

Copy link

github-actions bot commented Apr 8, 2024

CI build and push: At least one test failed ❌ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/8604109482

Copy link

github-actions bot commented Apr 8, 2024

No OpenAPI schema changes detected.

@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Apr 8, 2024

Workflow started at 4/8/2024, 1:22:19 PM. View Actions Run.

Copy link

github-actions bot commented Apr 8, 2024

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/8604184617

Copy link

github-actions bot commented Apr 8, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Apr 8, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8604184617

@andrewazores andrewazores merged commit fbb3088 into cryostatio:main Apr 9, 2024
8 checks passed
@andrewazores andrewazores deleted the id-request-filter-expressions branch April 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants