Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade quarkus to 3.2.9 #352

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

andrewazores
Copy link
Member

No description provided.

@andrewazores andrewazores requested a review from a team as a code owner April 5, 2024 15:11
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Apr 5, 2024
@andrewazores andrewazores added dependencies Pull requests that update a dependency file build chore Refactor, rename, cleanup, etc. safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Apr 5, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Apr 5, 2024

Workflow started at 4/5/2024, 11:12:26 AM. View Actions Run.

Copy link

github-actions bot commented Apr 5, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Apr 5, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8571934405

@andrewazores
Copy link
Member Author

This causes bytebuddy to be upgraded:

(main) $ mvn dependency:tree | grep bytebuddy
[INFO] |  |  +- net.bytebuddy:byte-buddy:jar:1.12.18:compile
[INFO] |  |     +- net.bytebuddy:byte-buddy-agent:jar:1.14.4:test

(quarkus-version) $ mvn dependency:tree | grep bytebuddy
[INFO] |  |  +- net.bytebuddy:byte-buddy:jar:1.14.7:compile
[INFO] |  |     +- net.bytebuddy:byte-buddy-agent:jar:1.14.4:test

The newer version here should support JDK 21. The CI runner for 21 looks like it's hanging however, but it's unclear why or if that's actually due to some problem with the application using JDK 21. It got further than it normally did with the new bytebuddy version, anyway.

raphw/byte-buddy#1396

@andrewazores
Copy link
Member Author

I see the same "JDP prune thread" shutdown hang behaviour when running tests locally using JDK 21 now.

@andrewazores andrewazores marked this pull request as draft April 5, 2024 15:32
@andrewazores andrewazores force-pushed the quarkus-version branch 2 times, most recently from e6bc66b to cbd3a63 Compare April 5, 2024 16:32
@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Apr 5, 2024

Workflow started at 4/5/2024, 12:34:15 PM. View Actions Run.

Copy link

github-actions bot commented Apr 5, 2024

CI build and push: At least one test failed ❌ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/8571934405

Copy link

github-actions bot commented Apr 5, 2024

No OpenAPI schema changes detected.

Copy link

github-actions bot commented Apr 5, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8572918569

Copy link

github-actions bot commented Apr 5, 2024

CI build and push: At least one test failed ❌ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/8572918569

@andrewazores
Copy link
Member Author

The JDK 21 thread hang doesn't appear to happen with #351 , so it looks like some threading interaction between older Quarkus and/or how we're using it, and JDK 21. Upgrading the Quarkus version and JDK version at the same time should get around it.

@andrewazores andrewazores marked this pull request as ready for review April 11, 2024 14:13
@andrewazores andrewazores merged commit bbbbf38 into cryostatio:main Apr 11, 2024
6 of 7 checks passed
@andrewazores andrewazores deleted the quarkus-version branch April 11, 2024 14:14
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 15, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 15, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 15, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 15, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 15, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 15, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 18, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 18, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 18, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 18, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 23, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 23, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 23, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 23, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 23, 2024
andrewazores added a commit to andrewazores/cryostat3 that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant