Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): refactor bucket check/create on startup #321

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Mar 8, 2024
@andrewazores andrewazores requested review from aali309 and mwangggg March 8, 2024 16:38
Copy link

github-actions bot commented Mar 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Mar 8, 2024

Workflow started at 3/8/2024, 11:38:48 AM. View Actions Run.

Copy link

github-actions bot commented Mar 8, 2024

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/8206295203

Copy link

github-actions bot commented Mar 8, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8206295203

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@andrewazores andrewazores merged commit 141dcbe into cryostatio:main Mar 11, 2024
6 of 7 checks passed
@andrewazores andrewazores deleted the bucket-creation branch March 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants