Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(archives): accept and delete recording uploads, emit event with correct size #314

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #2
Depends on cryostatio/cryostat-web#1221

Description of the change:

  1. Inserts the correct archived recording filesize into the WebSocket notification emitted when recordings are uploaded into archival storage
  2. Corrects handling of archives to allow null JVM IDs, which is the case for client uploads
  3. Corrects handling of archived recording deletion to accept "uploads" as a pseudo-"JVM ID", since that is how they are stored when uploaded

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

Copy link

github-actions bot commented Mar 4, 2024

@andrewazores
Copy link
Member Author

/build_test

Copy link

github-actions bot commented Mar 4, 2024

Workflow started at 3/4/2024, 2:48:56 PM. View Actions Run.

Copy link

github-actions bot commented Mar 4, 2024

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/8146118221

Copy link

github-actions bot commented Mar 4, 2024

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/8146118221

@andrewazores andrewazores requested review from aali309 and mwangggg March 4, 2024 19:56
@andrewazores andrewazores merged commit ff58a5b into cryostatio:main Mar 4, 2024
7 of 8 checks passed
@andrewazores andrewazores deleted the recording-uploads branch March 4, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants