Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): replace minio client with AWS S3 SDK client #3

Merged
merged 15 commits into from
Jun 8, 2023
Merged

feat(storage): replace minio client with AWS S3 SDK client #3

merged 15 commits into from
Jun 8, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jun 7, 2023 •
edited
Loading

No description provided.

andrewazores added 15 commits June 8, 2023 15:45
@andrewazores
update node version
5701976
@andrewazores
fix bug looking up wrong recording ID
20b9f09
@andrewazores
fixup! chore(pom): add s3 client extension dependency
542ba10
@andrewazores
configure minio as s3-compatible backend
431a209
@andrewazores
remove old downstream minio config, replace with (commented) localsta…
79e790e 
…ck config
@andrewazores
working on replacing minio client with AWS S3 SDK client
4f953f9
@andrewazores
correctly complete multipart uploads to s3
0deb549
@andrewazores
only abort upload if it has actually been started
7ec3f86
@andrewazores
handle metadata passed with active recording creation request
492e61d
@andrewazores
refactoring
cf331c8
@andrewazores
refactor to reuse common utility
0b067e8
@andrewazores
bugfix: don't close recording when entity is stopped, just stop the r…
2a382b9 
…emote recording
@andrewazores
remove minio dependency
fb4234c
@andrewazores
set s3 "path-style-access" as a property specific for minio
6d4429f
@andrewazores
base64 encode labels before putting into object tags
da01170
@andrewazores andrewazores merged commit 35410ef into cryostatio:main Jun 8, 2023
@andrewazores andrewazores deleted the s3 branch June 8, 2023 20:25
@andrewazores andrewazores mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewazores